Closed
Bug 711595
Opened 14 years ago
Closed 14 years ago
Request desktop site should be disabled for the same URIs as share
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(firefox11 verified, firefox12 verified, fennec11+)
VERIFIED
FIXED
Firefox 12
People
(Reporter: cpeterson, Assigned: Margaret)
Details
Attachments
(1 file)
|
2.04 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR:
1. Load Add-ons Manager (or about:home)
2. Open app menu
RESULT:
Bookmark this page, "Save as PDF", and "Request Desktop Site" are also unexpectedly enabled. This breaks the illusion that the about: pages are part of the native application.
|
||
Comment 1•14 years ago
|
||
* Bookmarking should always be allowed, these are in-content UI pages.
* Save as PDF should work as long as the underlying content supports it (bug 707665)
* Share should be disabled (bug 703630)
* Request desktop site should probably be disabled for the same sites as share (bug 703630)
|
||
Updated•14 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 2•14 years ago
|
||
What needs to be done here? Just disable the "Request Desktop Site" item?
|
|
||
Comment 3•14 years ago
|
||
(In reply to Margaret Leibovic [:margaret] from comment #2)
> What needs to be done here? Just disable the "Request Desktop Site" item?
I think so
|
||
Comment 4•14 years ago
|
||
I thought we are removing/disbaling Request Desktop Site?
|
|
||
Comment 5•14 years ago
|
||
(In reply to Kevin Brosnan [:kbrosnan] from comment #4)
> I thought we are removing/disbaling Request Desktop Site?
It's possible, but I have not seen the confirmation yet. Even if we do remove "Request Desktop Site" from Aurora, It could stay in Nightly.
|
|
Assignee | |
Comment 6•14 years ago
|
||
Assignee: nobody → margaret.leibovic
Status: NEW → ASSIGNED
Attachment #583295 -
Flags: review?(mark.finkle)
|
|
Assignee | |
Comment 7•14 years ago
|
||
Updating the summary to reflect what we're doing here.
Summary: Fennec about: pages can be bookmarked, saved as PDF, Request Desktop Site like real web pages → Request desktop site should be disabled for the same URIs as share
|
|
||
Updated•14 years ago
|
Attachment #583295 -
Flags: review?(mark.finkle) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [fennec-aurora]
|
|
Assignee | |
Comment 8•14 years ago
|
||
|
|
Assignee | |
Comment 9•14 years ago
|
||
Landed on aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/082fbd45ff4a
|
|
||
Comment 10•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
|
|
||
Updated•14 years ago
|
tracking-fennec: --- → 11+
|
|
||
Comment 11•14 years ago
|
||
Comment on attachment 583295 [details] [diff] [review]
patch
[Approval Request Comment]
Menu cleanup. Some menu items need to be disabled for certain content types
Low risk
Attachment #583295 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•14 years ago
|
status-firefox11:
--- → affected
status-firefox12:
--- → fixed
|
|
||
Updated•14 years ago
|
Whiteboard: [fennec-aurora]
|
|
||
Comment 12•14 years ago
|
||
Comment on attachment 583295 [details] [diff] [review]
patch
[Triage Comment]
Mobile only - approved for Aurora.
Attachment #583295 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 13•14 years ago
|
||
It looks like I landed this on aurora before we had the approval/tracking flags.
|
||
Comment 14•13 years ago
|
||
Verified fixed on Nightly 12.0a1 (2012-01-30)
Aurora 11.0a2 (2012-01-30)
Device:Samsung Galaxy S2 (Android 2.3.4)
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•