Closed Bug 711658 Opened 8 years ago Closed 8 years ago

Intergrated gpu no longer used on Nightly

Categories

(Core :: General, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12
Tracking Status
firefox11 + fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Keywords: regression, Whiteboard: [qa?])

Attachments

(1 file)

Looks like it was caused by 696376
Jeff, this needs to sort of block Fx11, right?
Blocks: 696376
Keywords: regression
Jeff, was this caused by
https://hg.mozilla.org/mozilla-central/rev/c9a74f4ee1f7

That is really strange, but most things about 696376 are. Can you confirm that that was the patch that broke it?
This moves the copy of NS_CompareVersions into the header to make things work.
Attachment #582874 - Flags: review?(bgirard)
Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

Review of attachment 582874 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #582874 - Flags: review?(bgirard) → review+
Please land on m-c and nominate for Aurora 11 approval. Thanks!
https://hg.mozilla.org/mozilla-central/rev/2325e88b6026
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

[Approval Request Comment]
Regression caused by (bug #): 696376
User impact if declined: We end up always using the discrete GPU (i.e. worse battery life)
Testing completed (on m-c, etc.): none yet
Risk to taking this patch (and alternatives if risky): Low, this just calls an independent function earlier.
Attachment #582874 - Flags: approval-mozilla-aurora?
Blocks: 715802
Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

[Triage Comment]
Approved for Aurora given where we are in the cycle, the risk assessment of this code change, and the impact to a user's battery life.
Attachment #582874 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This actually made it into Aurora but I forgot to include a link:
https://hg.mozilla.org/mozilla-beta/rev/2325e88b6026
Assignee: nobody → jmuizelaar
Is there anything QA can do to verify this bug?
Whiteboard: [qa?]
You need to log in before you can comment on or make changes to this bug.