711658 - Intergrated gpu no longer used on Nightly

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Looks like it was caused by 696376

Comment 1

[Boris Zbarsky [:bzbarsky]]

Jeff, this needs to sort of block Fx11, right?

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Jeff, was this caused by
https://hg.mozilla.org/mozilla-central/rev/c9a74f4ee1f7

That is really strange, but most things about 696376 are. Can you confirm that that was the patch that broke it?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Do TriggerQuirks earlier

This moves the copy of NS_CompareVersions into the header to make things work.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

Review of attachment 582874 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[Alex Keybl [:akeybl]]

Please land on m-c and nominate for Aurora 11 approval. Thanks!

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/2325e88b6026

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

[Approval Request Comment]
Regression caused by (bug #): 696376
User impact if declined: We end up always using the discrete GPU (i.e. worse battery life)
Testing completed (on m-c, etc.): none yet
Risk to taking this patch (and alternatives if risky): Low, this just calls an independent function earlier.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 582874 [details] [diff] [review]
Do TriggerQuirks earlier

[Triage Comment]
Approved for Aurora given where we are in the cycle, the risk assessment of this code change, and the impact to a user's battery life.

Comment 9

[Jeff Muizelaar [:jrmuizel]]

This actually made it into Aurora but I forgot to include a link:
https://hg.mozilla.org/mozilla-beta/rev/2325e88b6026

Comment 10

[u279076]

Is there anything QA can do to verify this bug?