Closed Bug 715802 Opened 11 years ago Closed 11 years ago

Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late.

Categories

(SeaMonkey :: Startup & Profiles, defect)

Product:
SeaMonkey
Component:
Startup & Profiles
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.8+ fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.9
Tracking Flags:
Tracking Status
seamonkey2.8 + fixed

People

(Reporter: philip.chee, Assigned: Callek)

References

Details

Attachments

(1 file)

v1
645 bytes, patch
BenWa
: review+
neil
: approval-comm-aurora+
Details | Diff | Splinter Review 
Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late. This makes sure we're early enough.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Attached patch v1 — — Splinter Review 
Happy to accept Ben's review for SeaMonkey here, due to our overall lack of Mac Reviewers and Karsten being busy lately. (he reviewed the Firefox copy of this fix)
Attachment #590460 - Flags: review?(mnyromyr)
Attachment #590460 - Flags: review?(bgirard)
Comment on attachment 590460 [details] [diff] [review]
v1

Looks good to me, just watch out not to introduce static initializers that may trigger the incorrect default quirks unintentionally.
Attachment #590460 - Flags: review?(bgirard) → review+
Thanks Benoit. By the way how do we test this patch anyway?
The only way I know is to check on a newer 10.6 macbook pro with the program 'gfxCardStatus' and confirm that the application does not show up under Dependencies. We don't have the right hardware to write automated tests.
Comment on attachment 590460 [details] [diff] [review]
v1

I don't have a multi-GPU MacBook Pro and I'm not sufficiently familiar with the code in question to review without testing. If stefanh can't do either, we probably need to just take it fingers crossed. :-|
Attachment #590460 - Flags: review?(mnyromyr) → review?(stefanh)
http://hg.mozilla.org/comm-central/rev/8bfedaa2586d

Still would love stefanh's review.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.9
Comment on attachment 590460 [details] [diff] [review]
v1

BenWa said he would be happy to test this in a nightly for us at some point this week as well.
Attachment #590460 - Flags: approval-comm-aurora?
Comment on attachment 590460 [details] [diff] [review]
v1

Ben, our nightlies have this now. Please verify for us. Thank you
Attachment #590460 - Flags: feedback?(bgirard)
Comment on attachment 590460 [details] [diff] [review]
v1

Sorry, I don't have a multi-GPU Mac. I might be able to get access to one, but we're probably talking weeks here...
Attachment #590460 - Flags: review?(stefanh)
BenWa told me this doesn't work overall, will be filing followup bug with his patch:

http://pastebin.mozilla.org/1461815
Attachment #590460 - Flags: feedback?(bgirard)
Blocks: 721285
No longer blocks: 721285
Depends on: 721285
Attachment #590460 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.