Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late.

RESOLVED FIXED in seamonkey2.9

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philip.chee, Assigned: Callek)

Tracking

Trunk
seamonkey2.9
All
macOS
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.8+ fixed)

Details

Attachments

(1 attachment)

Reporter

Description

8 years ago
Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late. This makes sure we're early enough.
Reporter

Updated

8 years ago
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Assignee

Comment 1

8 years ago
Posted patch v1Splinter Review
Happy to accept Ben's review for SeaMonkey here, due to our overall lack of Mac Reviewers and Karsten being busy lately. (he reviewed the Firefox copy of this fix)
Attachment #590460 - Flags: review?(mnyromyr)
Attachment #590460 - Flags: review?(bgirard)
Comment on attachment 590460 [details] [diff] [review]
v1

Looks good to me, just watch out not to introduce static initializers that may trigger the incorrect default quirks unintentionally.
Attachment #590460 - Flags: review?(bgirard) → review+
Reporter

Comment 3

8 years ago
Thanks Benoit. By the way how do we test this patch anyway?
The only way I know is to check on a newer 10.6 macbook pro with the program 'gfxCardStatus' and confirm that the application does not show up under Dependencies. We don't have the right hardware to write automated tests.
Comment on attachment 590460 [details] [diff] [review]
v1

I don't have a multi-GPU MacBook Pro and I'm not sufficiently familiar with the code in question to review without testing. If stefanh can't do either, we probably need to just take it fingers crossed. :-|
Attachment #590460 - Flags: review?(mnyromyr) → review?(stefanh)
Assignee

Comment 6

8 years ago
http://hg.mozilla.org/comm-central/rev/8bfedaa2586d

Still would love stefanh's review.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee

Updated

8 years ago
Target Milestone: --- → seamonkey2.9
Assignee

Comment 7

8 years ago
Comment on attachment 590460 [details] [diff] [review]
v1

BenWa said he would be happy to test this in a nightly for us at some point this week as well.
Attachment #590460 - Flags: approval-comm-aurora?
Assignee

Comment 8

8 years ago
Comment on attachment 590460 [details] [diff] [review]
v1

Ben, our nightlies have this now. Please verify for us. Thank you
Attachment #590460 - Flags: feedback?(bgirard)

Comment 9

8 years ago
Comment on attachment 590460 [details] [diff] [review]
v1

Sorry, I don't have a multi-GPU Mac. I might be able to get access to one, but we're probably talking weeks here...
Attachment #590460 - Flags: review?(stefanh)
Assignee

Comment 10

8 years ago
BenWa told me this doesn't work overall, will be filing followup bug with his patch:

http://pastebin.mozilla.org/1461815
Assignee

Updated

8 years ago
Attachment #590460 - Flags: feedback?(bgirard)
Assignee

Updated

8 years ago
Blocks: 721285
Reporter

Updated

8 years ago
No longer blocks: 721285
Depends on: 721285
Attachment #590460 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.