Closed
Bug 715802
Opened 11 years ago
Closed 11 years ago
Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late.
Categories
(SeaMonkey :: Startup & Profiles, defect)
Tracking
(seamonkey2.8+ fixed)
RESOLVED
FIXED
seamonkey2.9
People
(Reporter: philip.chee, Assigned: Callek)
References
Details
Attachments
(1 file)
645 bytes,
patch
|
BenWa
:
review+
neil
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late. This makes sure we're early enough.
![]() |
Reporter | |
Updated•11 years ago
|
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Happy to accept Ben's review for SeaMonkey here, due to our overall lack of Mac Reviewers and Karsten being busy lately. (he reviewed the Firefox copy of this fix)
Attachment #590460 -
Flags: review?(mnyromyr)
Attachment #590460 -
Flags: review?(bgirard)
Comment 2•11 years ago
|
||
Comment on attachment 590460 [details] [diff] [review] v1 Looks good to me, just watch out not to introduce static initializers that may trigger the incorrect default quirks unintentionally.
Attachment #590460 -
Flags: review?(bgirard) → review+
![]() |
Reporter | |
Comment 3•11 years ago
|
||
Thanks Benoit. By the way how do we test this patch anyway?
Comment 4•11 years ago
|
||
The only way I know is to check on a newer 10.6 macbook pro with the program 'gfxCardStatus' and confirm that the application does not show up under Dependencies. We don't have the right hardware to write automated tests.
Comment 5•11 years ago
|
||
Comment on attachment 590460 [details] [diff] [review] v1 I don't have a multi-GPU MacBook Pro and I'm not sufficiently familiar with the code in question to review without testing. If stefanh can't do either, we probably need to just take it fingers crossed. :-|
Attachment #590460 -
Flags: review?(mnyromyr) → review?(stefanh)
Assignee | ||
Comment 6•11 years ago
|
||
http://hg.mozilla.org/comm-central/rev/8bfedaa2586d Still would love stefanh's review.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → seamonkey2.9
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 590460 [details] [diff] [review] v1 BenWa said he would be happy to test this in a nightly for us at some point this week as well.
Attachment #590460 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 590460 [details] [diff] [review] v1 Ben, our nightlies have this now. Please verify for us. Thank you
Attachment #590460 -
Flags: feedback?(bgirard)
Comment 9•11 years ago
|
||
Comment on attachment 590460 [details] [diff] [review] v1 Sorry, I don't have a multi-GPU Mac. I might be able to get access to one, but we're probably talking weeks here...
Attachment #590460 -
Flags: review?(stefanh)
Assignee | ||
Comment 10•11 years ago
|
||
BenWa told me this doesn't work overall, will be filing followup bug with his patch: http://pastebin.mozilla.org/1461815
Assignee | ||
Updated•11 years ago
|
Attachment #590460 -
Flags: feedback?(bgirard)
![]() |
Reporter | |
Updated•11 years ago
|
Updated•11 years ago
|
Attachment #590460 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Assignee | ||
Comment 11•11 years ago
|
||
http://hg.mozilla.org/releases/comm-aurora/rev/81ff7636686c
You need to log in
before you can comment on or make changes to this bug.
Description
•