715802 - Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late.

Status: RESOLVED FIXED

Description

[Philip Chee]

Move quirks triggering into nsSuiteApp.cpp because Bug 696376 caused our quirks to be triggered too late. This makes sure we're early enough.

Comment 1

[Justin Wood (:Callek)]

Attachment: v1

Happy to accept Ben's review for SeaMonkey here, due to our overall lack of Mac Reviewers and Karsten being busy lately. (he reviewed the Firefox copy of this fix)

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 590460 [details] [diff] [review]
v1

Looks good to me, just watch out not to introduce static initializers that may trigger the incorrect default quirks unintentionally.

Comment 3

[Philip Chee]

Thanks Benoit. By the way how do we test this patch anyway?

Comment 4

[Benoit Girard (:BenWa)]

The only way I know is to check on a newer 10.6 macbook pro with the program 'gfxCardStatus' and confirm that the application does not show up under Dependencies. We don't have the right hardware to write automated tests.

Comment 5

[Karsten Düsterloh]

Comment on attachment 590460 [details] [diff] [review]
v1

I don't have a multi-GPU MacBook Pro and I'm not sufficiently familiar with the code in question to review without testing. If stefanh can't do either, we probably need to just take it fingers crossed. :-|

Comment 6

[Justin Wood (:Callek)]

http://hg.mozilla.org/comm-central/rev/8bfedaa2586d

Still would love stefanh's review.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 590460 [details] [diff] [review]
v1

BenWa said he would be happy to test this in a nightly for us at some point this week as well.

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 590460 [details] [diff] [review]
v1

Ben, our nightlies have this now. Please verify for us. Thank you

Comment 9

[Stefan [:stefanh]]

Comment on attachment 590460 [details] [diff] [review]
v1

Sorry, I don't have a multi-GPU Mac. I might be able to get access to one, but we're probably talking weeks here...

Comment 10

[Justin Wood (:Callek)]

BenWa told me this doesn't work overall, will be filing followup bug with his patch:

http://pastebin.mozilla.org/1461815

Comment 11

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-aurora/rev/81ff7636686c