711679 - Send background version checks to new domain

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Justin Scott [:fligtar]]

To help IT handle high load, we'd like the background update pings to be sent to a separate domain so that they can be turned off without affecting upgrade compatibility and other more important services.

This should involve cloning extensions.update.url and replacing the domain to be versioncheck-bg.addons.mozilla.org and using that setting when it's a background check.

Note that there is probably some trickery around add-ons that use a custom updateURL -- we shouldn't force them to set this property if possible, it should continue to work as it currently does and not ping us.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Which domain should hotfix checks use? It happens during the periodic background update check, but it's more important than a normal addon update.

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Until I get an answer to comment 1, this assumes the hotfix checks should use the new domain. But that's really simple to revert.

Comment 3

[Justin Scott [:fligtar]]

I don't think we need to special case the hotfix add-on unless it's super easy to do. My hope is that we will only ever need to use this rarely and for brief intervals.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Justin Scott [:fligtar] from comment #3)
> I don't think we need to special case the hotfix add-on unless it's super
> easy to do. My hope is that we will only ever need to use this rarely and
> for brief intervals.

It is super-easy to do - hotfixes have their own update logic, so it's a one-line fix to change which preference to use (I had to change that one line to make it use the new domain). Even the test was a one-line fix. So it's only a matter which is more appropriate.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/integration/fx-team/rev/b73fbdb5a5b5

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

For future reference: That patch made it so hotfix checks go to the new domain.

Comment 7

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/b73fbdb5a5b5