Last Comment Bug 711718 - Mac64 builds failing during packaging
: Mac64 builds failing during packaging
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All Mac OS X
: -- blocker (vote)
: Thunderbird 11.0
Assigned To: Justin Wood (:Callek)
:
:
Mentors:
Depends on: 712298
Blocks: 696436
  Show dependency treegraph
 
Reported: 2011-12-17 07:11 PST by Justin Wood (:Callek)
Modified: 2011-12-20 08:04 PST (History)
2 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed
fixed


Attachments
v1 (14.22 KB, patch)
2011-12-17 09:03 PST, Justin Wood (:Callek)
standard8: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review
Review diffs (5.11 KB, patch)
2011-12-17 11:14 PST, Mark Banner (:standard8)
no flags Details | Diff | Splinter Review

Description Justin Wood (:Callek) 2011-12-17 07:11:28 PST
Our current mac builds are failing during packaging, both SeaMonkey and TB.

From inspection of the affected range, it looks like it was the m-i merge at http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=dcf6e5163e63

Of which the most likely culprit seems to be gavin's Bug 696436 ( http://hg.mozilla.org/mozilla-central/rev/6b18f5259de9)

I'm working on a patch but unable to test easily, try might work though.
Comment 1 Justin Wood (:Callek) 2011-12-17 09:03:59 PST
Created attachment 582546 [details] [diff] [review]
v1

Attempt 1, untested so far.
Comment 2 Mark Banner (:standard8) 2011-12-17 11:14:47 PST
Created attachment 582554 [details] [diff] [review]
Review diffs

Diffs from my review, which I'll land with the patch.

I think this will get everything working again including suite, though I haven't explicitly tested that as I was running out of battery.
Comment 3 Mark Banner (:standard8) 2011-12-17 11:16:12 PST
Checked in:

http://hg.mozilla.org/comm-central/rev/9d95f09dada7
Comment 4 Mark Banner (:standard8) 2011-12-17 11:17:33 PST
Comment on attachment 582546 [details] [diff] [review]
v1

Assuming this passes build on trunk for Thunderbird and SeaMonkey, then you have a=me for transplanting the changeset I landed to Aurora.
Comment 5 Jens Hatlak (:InvisibleSmiley) 2011-12-17 13:58:24 PST
http://hg.mozilla.org/releases/comm-aurora/rev/cd28972a7708
on behalf of Callek (requested on IRC)

Note You need to log in before you can comment on or make changes to this bug.