Implement a fullscreen arrow for some windows in Thunderbird for 10.7 and above

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Nomis101, Assigned: Nomis101)

Tracking

(Blocks: 2 bugs)

unspecified
Thunderbird 17.0
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [gs], URL)

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

5 years ago
If Bug 639705 is fixed, we will have the Lion fullscreen arrow on every window in Thunderbird. This than works to bring this window into Lion fullscreen mode on 10.7. But the shortcut and some other things doesn't work. So we need to port the necessary parts from browser.js to Thunderbird.
For the record, bug 639705 will make native fullscreen opt-in (as <window fullscreenbutton="true">). So you aren't forced to support it until you want to (I vote that you should, but I'm not a heavy TB user).
(Assignee)

Updated

5 years ago
Blocks: 728438
(Assignee)

Comment 2

5 years ago
Created attachment 598699 [details] [diff] [review]
Enable Lion fullscreenmode for some windows

This patch enables Lion fullscreen for the main window, the standalone message window, the compose window and the addressbook. 
Keyboard shortcut doesn't work yet, because I'm not sure how to do that. Firefox uses shift+cmd+f which is in use in TB, OS X does ctrl+cmd+f.
Attachment #598699 - Flags: ui-review?(bwinton)
Comment on attachment 598699 [details] [diff] [review]
Enable Lion fullscreenmode for some windows

That seems reasonable, although I'ld kind of like to see it in action before we check it in…  (And the patches from bug 639705 didn't apply, so it's going to have to wait a little while.)

Thanks,
Blake.
Attachment #598699 - Flags: ui-review?(bwinton) → feedback+
(Assignee)

Comment 4

5 years ago
Yes, we need to wait for Bug 639705 to get fixed, before this can get in. I don't have access to the tryserver, so I can't provide a try build...
Blake could you push to try ?
This patch appears to have bitrotted.  Can it be updated?
(Assignee)

Comment 7

5 years ago
Created attachment 605503 [details] [diff] [review]
Unbitrotted patch

(In reply to Ludovic Hirlimann [:Usul] from comment #5)
> Blake could you push to try ?
This will only work together with the patches from Bug 639705.

(In reply to Mike Conley (:mconley) from comment #6)
> This patch appears to have bitrotted.  Can it be updated?
Hah, this was bitrotted because of my own patch.^^
Comment on attachment 605503 [details] [diff] [review]
Unbitrotted patch

Seems to work over here.  There are some oddities I'm not too happy with, like when I open a Compose window from a full-screened 3-pane, the new compose window is also full-screened, but I don't think that's something we can change in Thunderbird, so I'm going to say r=me, but I think I want a menu item saying "View » Enter Full Screen    ^⌘F" (changing to "View » Exit Full Screen    ^⌘F" when the window is in full-screen mode) before I give it the ui-r.  And yes, I checked the ^⌘F is free in all three windows. ;)

Thanks,
Blake.
Attachment #605503 - Flags: ui-review-
Attachment #605503 - Flags: review+
(Assignee)

Comment 9

5 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #8)
> Comment on attachment 605503 [details] [diff] [review]
> Unbitrotted patch
> but I think I want a
> menu item saying "View » Enter Full Screen    ^⌘F" (changing to "View » Exit
> Full Screen    ^⌘F" when the window is in full-screen mode) before I give it
> the ui-r.  And yes, I checked the ^⌘F is free in all three windows. ;)
> 
> Thanks,
> Blake.

Yes, that would be nice, but somebody other needs to do this, I can integrate the menu item into "View", but I have no idea how to make it functional. :-(
Tell you what, you add the buttons, with an action of "dump('Aaahhh!\n')", and I'll figure out what that code should actually be.  ;)
And it looks like it should be something along the lines of "window.fullScreen = !window.fullScreen".  :)
I started doing exactly this in Firefox (attachment 586156 [details] [diff] [review] in bug 714172), you may want to see what's happening there.

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #11)
> And it looks like it should be something along the lines of
> "window.fullScreen = !window.fullScreen".  :)

Pretty much, though you'll need to listen for the "fullscreen" event to change the menu.
(Assignee)

Comment 13

5 years ago
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> Tell you what, you add the buttons, with an action of "dump('Aaahhh!\n')",
> and I'll figure out what that code should actually be.  ;)
Cool, I will do that on the weekend. :-)

(In reply to Paul O'Shannessy [:zpao] from comment #12)
> I started doing exactly this in Firefox (attachment 586156 [details] [diff] [review]
> [review] in bug 714172), you may want to see what's happening there.
Thats very helpfull thanks.
(Assignee)

Comment 14

5 years ago
(In reply to Nomis101 from comment #13)
> (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> > Tell you what, you add the buttons, with an action of "dump('Aaahhh!\n')",
> > and I'll figure out what that code should actually be.  ;)
> Cool, I will do that on the weekend. :-)
OK, this was a bit optimistic. Just to let you know, this is still on my ToDo-List. But everything I've tried for now messed up the Thunderbird UI completely. So I first need to ask what I did wrong on IRC (or so). But currently I have no time for that. But its still on my ToDo-List.
(Assignee)

Comment 15

5 years ago
Created attachment 629654 [details] [diff] [review]
This does not work!

(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #10)
> Tell you what, you add the buttons, with an action of "dump('Aaahhh!\n')",
> and I'll figure out what that code should actually be.  ;)

I hope you also can tell me why this does not work. It doesn't add any button, it only breaks TB and makes it completely unusable. :-( How do I get the button in the view menu?
Attachment #598699 - Attachment is obsolete: true
Whiteboard: [gs]
(Assignee)

Updated

5 years ago
Blocks: 783864
(Assignee)

Updated

5 years ago
Summary: [10.7] Finalize Lion fullscreen support in Thunderbird → Implement a fullscreen arrow for some windows in Thunderbird for 10.7 and above
(Assignee)

Updated

5 years ago
Attachment #629654 - Attachment is obsolete: true
(Assignee)

Comment 16

5 years ago
Created attachment 653159 [details] [diff] [review]
Patch for initial fullscreen support

I've tried a lot of things, asked on IRC and so on to implement the menu
bwinton asked for in #8. But nothing was really successfully. So I talked to bwinton and he told me, he is OK if I only implement the fullscreen arrow and someone other than can implement the menu in a followup bug. This patch will now only implement the arrow, the followup bug is 783864.
Attachment #605503 - Attachment is obsolete: true
Attachment #653159 - Flags: review?(bwinton)
Comment on attachment 653159 [details] [diff] [review]
Patch for initial fullscreen support

Sold.  r=me!

Thanks,
Blake.
Attachment #653159 - Flags: review?(bwinton) → review+
Keywords: checkin-needed
comm-central: https://hg.mozilla.org/comm-central/rev/73f6649143ef
Assignee: nobody → Nomis101
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.