71179 - QNX photon port requires changes to the prlink.c to run 4x netscape plugins

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[timeless]

patch is attached to message in url. please help get this (or a derivative) 
checked in.

Comment 1

[timeless]

attaching patch based on poor man's merge. *untested*

Comment 2

[timeless]

Attachment: changes to mozilla/nsprpub

Comment 3

[timeless]

Is this still needed?

Comment 4

[larryh (gone)]

The proposed patch changes the API, adding a symbol to the arguments. Suggest a 
better patch, please, that does not change the API.

Comment 5

[Brendan Eich [:brendan]]

What's RTLD_GROUP, exactly?  man -k isn't helping me on RH Linux.

Larry, could this be considered for a future major release of NSPR?

/be

Comment 6

[Brian Edmond]

This bug is a duplicate of 71182, and a patch is available there.

*** This bug has been marked as a duplicate of 71182 ***

Comment 7

[Wan-Teh Chang]

I will not add the PR_LD_GROUP flag to the NSPR prlink.h API.
It is not clear whether this loading option can be implemented
cross-platform.

You have two options:
1. If it is fine for PR_LoadLibraryWithFlags() to always pass
   RTLD_GROUP to dlopen(), you can modify
   mozilla/nsprpub/pr/src/linking/prlink.c as follows:

Index: prlink.c
===================================================================
RCS file: /cvsroot/mozilla/nsprpub/pr/src/linking/prlink.c,v
retrieving revision 3.34.2.9
diff -u -r3.34.2.9 prlink.c
--- prlink.c	2001/05/22 23:31:57	3.34.2.9
+++ prlink.c	2001/05/24 20:56:40
@@ -728,7 +728,11 @@
 #ifdef HAVE_DLL
     {
 #if defined(USE_DLFCN)
+#ifdef NTO
+    int dl_flags = RTLD_GROUP;
+#else
     int dl_flags = 0;
+#endif
     void *h;
 
     if (flags & PR_LD_LAZY) {

2. In mozilla/modules/plugin/nglsrc/nsPluginsDirUnix.cpp,
   call dlopen() directly, instead of PR_LoadLibraryWithFlags(),
   on Neutrino.

Comment 8

[timeless]

[e-mail]: the reason I filed two bugs is that NSPR is a locked module, 
whereas plugins is not. The code while related was at least somewhat seperable.

However, I filed these bugs to get work done, and since you and wtc are both 
now considering getting it done I don't care how or where you do it. [Although 
it's impossible and impracticle for me to remove myself as reporter]

Comment 9

[Wan-Teh Chang]

This bug is to address the NSPR part of the problem.
Bug 71182 is to address the browser part of the problem.

Comment 10

[Wan-Teh Chang]

Attachment: Proposed patch. PR_LoadLibraryWithFlags always uses RTLD_GROUP on Neutrino.

Comment 11

[Wan-Teh Chang]

I checked in my patch on the tip of NSPR.  I will
check it in on the NSPRPUB_PRE_4_2_CLIENT_BRANCH
when the Mozilla tree opens.

Comment 12

[Wan-Teh Chang]

Fix checked in on the NSPRPUB_PRE_4_2_CLIENT_BRANCH.