Closed Bug 711966 Opened 9 years ago Closed 9 years ago

Change Tilt button label to "3D View" and the accesskey to "w"

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 12

People

(Reporter: rcampbell, Assigned: vporof)

Details

(Keywords: dev-doc-complete, Whiteboard: [tilt])

Attachments

(2 files, 5 obsolete files)

Follow up from bug 689920.

The accelerator key for the 3D menu button in the Page Inspector is 'M'. We should change this to the number '3' key for Windows and Linux to match the string.
Attached patch v1 (obsolete) — Splinter Review
Also changed access key to D on mac.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #582836 - Flags: review?(rcampbell)
Whiteboard: [tilt]
There should be at least a localization note in the DTD file telling localizers that accesskey2 is for Mac...
Attached patch v2 (obsolete) — Splinter Review
Added localization note.
Attachment #582836 - Attachment is obsolete: true
Attachment #582836 - Flags: review?(rcampbell)
Attachment #582888 - Flags: review?(rcampbell)
Comment on attachment 582888 [details] [diff] [review]
v2

Alt+3 selects the third tab on Linux.
Attachment #582888 - Flags: review?(rcampbell) → review-
Any reason against using D across platforms?
(In reply to Dão Gottwald [:dao] from comment #5)
> Any reason against using D across platforms?

Alt+D focuses the awesomebar on Windows.
(In reply to Dão Gottwald [:dao] from comment #4)
> Comment on attachment 582888 [details] [diff] [review]
> v2
> 
> Alt+3 selects the third tab on Linux.

Maybe we can use 3 on Windows, D on Mac OS X and Linux? I just tested in Windows, Alt+3 doesn't apparently do anything.
that could work but it sure is a lot of keys for one button. :)
Summary: Change Tilt accesskey to 3 on Linux and Windows → Change Tilt accesskey to "3" on Windows and "D" on OS X and Linux
Attached patch v3 (obsolete) — Splinter Review
Attachment #582888 - Attachment is obsolete: true
Attachment #584169 - Flags: review?(rcampbell)
Attachment #584169 - Flags: review?(dao)
Comment on attachment 584169 [details] [diff] [review]
v3

- use #ifdef XP_WIN
- set inspect3DButton.accesskey to D
- add inspect3DButton.windowsAccesskey with 3
Attachment #584169 - Flags: review?(dao) → review-
(In reply to Victor Porof from comment #7)
> (In reply to Dão Gottwald [:dao] from comment #4)
> > Comment on attachment 582888 [details] [diff] [review]
> > v2
> > 
> > Alt+3 selects the third tab on Linux.
> 
> Maybe we can use 3 on Windows, D on Mac OS X and Linux? I just tested in
> Windows, Alt+3 doesn't apparently do anything.

Err, doesn't Alt+D focus the location bar on Linux as well?
Attached patch v4 (obsolete) — Splinter Review
Addressed Dão's review comments.
Attachment #584175 - Flags: review?(rcampbell)
Attachment #584175 - Flags: review?(dao)
Comment on attachment 584175 [details] [diff] [review]
v4

-> comment 11 :(
Attachment #584175 - Flags: review?(dao) → review-
(In reply to Dão Gottwald [:dao] from comment #13)
> Comment on attachment 584175 [details] [diff] [review]
> v4
> 
> -> comment 11 :(

Just saw it. Hmm, yes, it does.
3 on Windows and Linux, D on Mac?
(In reply to Victor Porof from comment #14)
> (In reply to Dão Gottwald [:dao] from comment #13)
> > Comment on attachment 584175 [details] [diff] [review]
> > v4
> > 
> > -> comment 11 :(
> 
> Just saw it. Hmm, yes, it does.
> 3 on Windows and Linux, D on Mac?

Wait, no, comment 4 :(
Any other suggestions?
Label the button "3D View" and use V?
(In reply to Dão Gottwald [:dao] from comment #16)
> Label the button "3D View" and use V?

Or "3D DOM" and continue using M. Which one sounds better?
3D DOM doesn't seem to make sense to me...
Attached patch v5 (obsolete) — Splinter Review
Attachment #584169 - Attachment is obsolete: true
Attachment #584175 - Attachment is obsolete: true
Attachment #584169 - Flags: review?(rcampbell)
Attachment #584175 - Flags: review?(rcampbell)
Attachment #584177 - Flags: review?(rcampbell)
Attachment #584177 - Flags: review?(dao)
Alt+V opens the View menu on Linux (probably Windows too).
I think we should WONTFIX this one.
Comment on attachment 584177 [details] [diff] [review]
v5

We need to change the entity name here... Localizers have already picked up 3D on aurora, together with random bogus access keys.
Attachment #584177 - Flags: review?(dao) → review-
(In reply to Victor Porof from comment #20)
> Alt+V opens the View menu on Linux (probably Windows too).
> I think we should WONTFIX this one.

Alt+W?
(In reply to Dão Gottwald [:dao] from comment #21)
> Comment on attachment 584177 [details] [diff] [review]
> v5
> 
> We need to change the entity name here... Localizers have already picked up
> 3D on aurora, together with random bogus access keys.

Is inspect3DButton.accesskey3d a good entity name?
No, accesskey3d doesn't make sense... You could just call it inspect3DViewButton.accesskey.
Attached patch v6Splinter Review
Found a better solution.
Attachment #584177 - Attachment is obsolete: true
Attachment #584177 - Flags: review?(rcampbell)
Attachment #584179 - Flags: review?(dao)
Comment on attachment 584179 [details] [diff] [review]
v6

>+<!-- LOCALIZATION NOTE (inspect3DButton.label): This button shows an alternate
>+  -  view for the Inspector, creating a 3D visualization of the webpage. -->
>+<!ENTITY inspect3DViewButton.label     "3D View">

update the entity reference in the localization note
Attachment #584179 - Flags: review?(dao) → review+
What can we do to prevent locales from picking access keys that conflict with the menu bar?
Attached patch [in-fx-team] v7Splinter Review
Seventh time the charm :)
Attachment #584180 - Flags: review?(rcampbell)
Attachment #584180 - Flags: review?(dao)
(In reply to Dão Gottwald [:dao] from comment #27)
> What can we do to prevent locales from picking access keys that conflict
> with the menu bar?

For Tilt specifically, we could add a test to check if using the access key indeed opens the visualization.
Attachment #584180 - Flags: review?(dao) → review+
(In reply to Victor Porof from comment #29)
> (In reply to Dão Gottwald [:dao] from comment #27)
> > What can we do to prevent locales from picking access keys that conflict
> > with the menu bar?
> 
> For Tilt specifically, we could add a test to check if using the access key
> indeed opens the visualization.

Well, we'd to run that test on localized builds... The concern also isn't limited to this single button.
(In reply to Dão Gottwald [:dao] from comment #30)
> (In reply to Victor Porof from comment #29)
> > (In reply to Dão Gottwald [:dao] from comment #27)
> > > What can we do to prevent locales from picking access keys that conflict
> > > with the menu bar?
> > 
> > For Tilt specifically, we could add a test to check if using the access key
> > indeed opens the visualization.
> 
> Well, we'd to run that test on localized builds... The concern also isn't
> limited to this single button.

Filed bug 713391 for this.
Comment on attachment 584180 [details] [diff] [review]
[in-fx-team] v7

W, eh? Why not!
Attachment #584180 - Flags: review?(rcampbell) → review+
So can we land this? :)
yes. please put [land-in-fx-team] in the status whiteboard when ready to ship.
Whiteboard: [tilt] → [tilt][land-in-fx-team]
Comment on attachment 584180 [details] [diff] [review]
[in-fx-team] v7

Landed:
https://hg.mozilla.org/integration/fx-team/rev/268524cb6639

Quick note: accesskeys are case sensitive. You have "3D View" with "W" which should have been lowercase. (unfortunately, I just noticed after landing)

For future reference, please check: https://developer.mozilla.org/en/XUL_Accesskey_FAQ_and_Policies
Attachment #584180 - Attachment description: v7 → [in-fx-team] v7
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
Will this make the button text be "3D View (W)"? We can do a quick follow-up.
(In reply to Victor Porof from comment #36)
> Will this make the button text be "3D View (W)"? We can do a quick follow-up.

I hope it won't.
Filed bug 718458.
https://hg.mozilla.org/mozilla-central/rev/268524cb6639
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
This landed with a nonsensical commit message :/
Summary: Change Tilt accesskey to "3" on Windows and "D" on OS X and Linux → Change Tilt button label to "3D View" and the accesskey to "w"
Copy Checkin Comment FTL.
This is already documented as "3D view"
This is already documented as "3D view"
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.