713391 - There should be a test to make sure Tilt is opened via the access key

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Victor Porof [:vporof][:vp]]

There were some talks about this necessity in bug 711966.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Axel Hecht [:Pike]]

We do have a dedicated set of mochitests for l10n, which are occasionally run.

Not sure if we're running other UI tests on localized builds even that often. Henrik?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Axel Hecht [:Pike] from comment #2)
> We do have a dedicated set of mochitests for l10n, which are occasionally
> run.

Do we? As far as I know all mochitests exercising the en-US access keys only. Can you point me to those?

> Not sure if we're running other UI tests on localized builds even that
> often. Henrik?

No, we don't do that yet. With Mozmill we have some tests which are using access keys (even the localized ones) but those tests get run only for releases (beta, final). The coverage is also minimal. That means if localizers would like to start testing access keys, I can kindly offer my help to get this type of tests started.

Comment 4

[Axel Hecht [:Pike]]

Yeah, confuzzled, I meant mozmill tests.

Comment 5

[Rob Campbell [:rc] (:robcee)]

guys, get a room.

Comment 6

[Victor Porof [:vporof][:vp]]

So is this something we can land or something we should always stay away from?

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 584211 [details] [diff] [review]
v1

Review of attachment 584211 [details] [diff] [review]:
-----------------------------------------------------------------

Victor, thanks for your patch!

We do have some tests that use keyboard shortcuts to access some of the features/commands of the devtools UI. However, having a specific test for the accesskey seems a bit "overkill" - there's not much value for a test that checks only this.

Rob, what do you think?

::: browser/devtools/tilt/test/browser_tilt_04_initialization-key.js
@@ +25,5 @@
> +
> +  id = TiltUtils.getWindowId(gBrowser.selectedBrowser.contentWindow);
> +  tiltKey = Tilt.tiltButton.getAttribute("accesskey");
> +
> +  if ("nsILocalFileMac" in Ci) {

Services.appinfo.OS == "Darwin"

Comment 8

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/0c90c1267f63

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/0c90c1267f63

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 584211 [details] [diff] [review]
v1

[Approval Request Comment]
Regression caused by (bug #): New feature
User impact if declined: None, but there is developer cost.
Testing completed (on m-c, etc.): mc
Risk to taking this patch (and alternatives if risky): Negative risk. Adds a test.