There should be a test to make sure Tilt is opened via the access key

RESOLVED FIXED in Firefox 12

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tilt][fixed-in-fx-team])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
There were some talks about this necessity in bug 711966.
(Assignee)

Updated

6 years ago
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Whiteboard: [tilt]
(Assignee)

Comment 1

6 years ago
Created attachment 584211 [details] [diff] [review]
v1
Attachment #584211 - Flags: review?(rcampbell)
(Assignee)

Updated

6 years ago
See Also: → bug 711966

Comment 2

6 years ago
We do have a dedicated set of mochitests for l10n, which are occasionally run.

Not sure if we're running other UI tests on localized builds even that often. Henrik?
(In reply to Axel Hecht [:Pike] from comment #2)
> We do have a dedicated set of mochitests for l10n, which are occasionally
> run.

Do we? As far as I know all mochitests exercising the en-US access keys only. Can you point me to those?

> Not sure if we're running other UI tests on localized builds even that
> often. Henrik?

No, we don't do that yet. With Mozmill we have some tests which are using access keys (even the localized ones) but those tests get run only for releases (beta, final). The coverage is also minimal. That means if localizers would like to start testing access keys, I can kindly offer my help to get this type of tests started.

Comment 4

6 years ago
Yeah, confuzzled, I meant mozmill tests.
guys, get a room.
(Assignee)

Comment 6

5 years ago
So is this something we can land or something we should always stay away from?
Comment on attachment 584211 [details] [diff] [review]
v1

Review of attachment 584211 [details] [diff] [review]:
-----------------------------------------------------------------

Victor, thanks for your patch!

We do have some tests that use keyboard shortcuts to access some of the features/commands of the devtools UI. However, having a specific test for the accesskey seems a bit "overkill" - there's not much value for a test that checks only this.

Rob, what do you think?

::: browser/devtools/tilt/test/browser_tilt_04_initialization-key.js
@@ +25,5 @@
> +
> +  id = TiltUtils.getWindowId(gBrowser.selectedBrowser.contentWindow);
> +  tiltKey = Tilt.tiltButton.getAttribute("accesskey");
> +
> +  if ("nsILocalFileMac" in Ci) {

Services.appinfo.OS == "Darwin"
Attachment #584211 - Flags: review?(rcampbell) → review+
Whiteboard: [tilt] → [tilt][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/0c90c1267f63
Whiteboard: [tilt][land-in-fx-team] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/0c90c1267f63
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 584211 [details] [diff] [review]
v1

[Approval Request Comment]
Regression caused by (bug #): New feature
User impact if declined: None, but there is developer cost.
Testing completed (on m-c, etc.): mc
Risk to taking this patch (and alternatives if risky): Negative risk. Adds a test.
Attachment #584211 - Flags: approval-mozilla-aurora?
tracking-firefox11: --- → ?
tracking-firefox11: ? → ---
Attachment #584211 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.