The default bug view has changed. See this FAQ.

Remove the Binder class from localStorage

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({perf})

unspecified
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
That's useless overhead afaict, BindingParamsArray is useful when you have to bind mutiple params in a single execution, that is never the case here.
I have the patch ready.
(Assignee)

Comment 1

5 years ago
Created attachment 583116 [details] [diff] [review]
patch v1.0

As I said, I don't think this class adds anything useful, apart some overhead.
Attachment #583116 - Flags: review?(honzab.moz)
The binder was there because there was not the API you are using now.

I'll review after the new year.
(Assignee)

Updated

5 years ago
Blocks: 714964
Comment on attachment 583116 [details] [diff] [review]
patch v1.0

Review of attachment 583116 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Thanks.
Attachment #583116 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf9bc81cfc0c
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/bf9bc81cfc0c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.