Closed
Bug 712006
Opened 13 years ago
Closed 12 years ago
Remove the Binder class from localStorage
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
13.14 KB,
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
That's useless overhead afaict, BindingParamsArray is useful when you have to bind mutiple params in a single execution, that is never the case here. I have the patch ready.
|
Assignee | |
Comment 1•13 years ago
|
||
As I said, I don't think this class adds anything useful, apart some overhead.
Attachment #583116 -
Flags: review?(honzab.moz)
|
||
Comment 2•13 years ago
|
||
The binder was there because there was not the API you are using now. I'll review after the new year.
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 583116 [details] [diff] [review] patch v1.0 Review of attachment 583116 [details] [diff] [review]: ----------------------------------------------------------------- r=honzab Thanks.
Attachment #583116 -
Flags: review?(honzab.moz) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf9bc81cfc0c
Target Milestone: --- → mozilla12
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf9bc81cfc0c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•