Last Comment Bug 711972 - Use a StatementCache in localStorage
: Use a StatementCache in localStorage
Status: RESOLVED FIXED
: perf
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Marco Bonardo [::mak] (Away 6-20 Aug)
:
Mentors:
Depends on: 711970
Blocks: 704933 712006 712009 714964
  Show dependency treegraph
 
Reported: 2011-12-19 06:45 PST by Marco Bonardo [::mak] (Away 6-20 Aug)
Modified: 2012-01-11 18:02 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1.0 (24.92 KB, patch)
2011-12-20 04:46 PST, Marco Bonardo [::mak] (Away 6-20 Aug)
honzab.moz: review+
Details | Diff | Splinter Review

Description Marco Bonardo [::mak] (Away 6-20 Aug) 2011-12-19 06:45:38 PST
There's no need to prepare all statements on startup, and simplifies shutdown management.
I have this patch ready.
Comment 1 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-12-20 04:46:16 PST
Created attachment 583115 [details] [diff] [review]
patch v1.0

The StatementCache has the advantage that it simplifies finalization, doesn't require to prepare all statements on startup and moves the statements near their use point, often clarifying the code.
In future it will also allow better memory management by automatically expiring statements unused for a certain amount of time.
Comment 2 Honza Bambas (:mayhemer) 2012-01-09 11:15:53 PST
Comment on attachment 583115 [details] [diff] [review]
patch v1.0

Review of attachment 583115 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Useful class :)  Thanks.  I trust you you have copied the statements char-by-char, I didn't check on it my self.
Comment 3 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-01-11 02:49:17 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/37c00830f599
Comment 4 Ed Morley [:emorley] 2012-01-11 18:02:23 PST
https://hg.mozilla.org/mozilla-central/rev/37c00830f599

Note You need to log in before you can comment on or make changes to this bug.