The default bug view has changed. See this FAQ.

Use a StatementCache in localStorage

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

({perf})

unspecified
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There's no need to prepare all statements on startup, and simplifies shutdown management.
I have this patch ready.
(Assignee)

Updated

5 years ago
Blocks: 712006
(Assignee)

Updated

5 years ago
Blocks: 712009
(Assignee)

Comment 1

5 years ago
Created attachment 583115 [details] [diff] [review]
patch v1.0

The StatementCache has the advantage that it simplifies finalization, doesn't require to prepare all statements on startup and moves the statements near their use point, often clarifying the code.
In future it will also allow better memory management by automatically expiring statements unused for a certain amount of time.
Attachment #583115 - Flags: review?(honzab.moz)
(Assignee)

Updated

5 years ago
Blocks: 714964
Comment on attachment 583115 [details] [diff] [review]
patch v1.0

Review of attachment 583115 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Useful class :)  Thanks.  I trust you you have copied the statements char-by-char, I didn't check on it my self.
Attachment #583115 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/37c00830f599
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/37c00830f599
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.