Closed Bug 712034 Opened 13 years ago Closed 13 years ago

Clean up jstypes.h

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: Waldo, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Bug 711672 comment 7: > Feel free to file as followup or ignore, but: it would be nice if jstypes.h > were mv'd to js/public. mfbt/Types.h will conflict if you just name it > js/public/Types.h. Looking at the remaining content of jstypes.h, there > isn't too much, and what there is isn't types. Perhaps it can just be > injected into js/public/Utility.h? Also there are a lot remaining goofballs > to be moved into LegacyIntTypes.h (JSWord, JSUWord, JSPtrDiff, JSSize, > JSInt, JSIntn...).
JSSize/JSPtrdiff/JSUptrdiff are completely unused, and can probably be removed.
Depends on: 714728
Depends on: 714052
Attached patch Patch v1Splinter Review
Assignee: general → Ms2ger
Status: NEW → ASSIGNED
Attachment #588377 - Flags: review?(n.nethercote)
Attachment #588377 - Flags: review?(n.nethercote) → review+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 725548
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: