725548 - [meta] Remove obsolete numeric typedefs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

jsdouble, etc--hopefully we don't need any of that stuff any more.

Comment 1

[David Mandelin [:dmandelin]]

JSBool is the only hard one. The reasons we have it:

1. In VS2005, in C, there is no bool type defined. This could be worked around easily enough with 'typedef int bool' for VS2005 only.

2. More importantly, |bool| doesn't give a size guarantee, which would make life harder for the JITs (and possibly certain other applications).

3. any others?

Regarding #2, we already use |bool| for internal APIs, so it seems like it would be pretty much the same as what we have now to use |bool| most places and use a special |jsbool| only when JITs actually call that function.

Comment 2

[David Mandelin [:dmandelin]]

Attachment: Python script for generic file munging

Comment 3

[Chris Leary [:cdleary] (not checking bugmail)]

(In reply to David Mandelin from comment #1)
> 1. In VS2005, in C, there is no bool type defined. This could be worked
> around easily enough with 'typedef int bool' for VS2005 only.

I thought C embedders tended to cry whenever a third-party header defined something to be bool, because they may have their own (incompatible, un-namespaced) internal definition as well.

Comment 4

[David Mandelin [:dmandelin]]

(In reply to Chris Leary [:cdleary] from comment #3)
> (In reply to David Mandelin from comment #1)
> > 1. In VS2005, in C, there is no bool type defined. This could be worked
> > around easily enough with 'typedef int bool' for VS2005 only.
> 
> I thought C embedders tended to cry whenever a third-party header defined
> something to be bool, because they may have their own (incompatible,
> un-namespaced) internal definition as well.

I was hoping that "embedding SpiderMonkey in C with VS2005" was sufficiently obscure that no one's even doing it. We could always fix it more if someone actually is.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Anything left to do here?

Comment 6

[Chris Peterson [:cpeterson]]

Anything left to do here? LegacyIntTypes.h defines some intX/uintX and JSIntX/JSUintX typedefs that are unused.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I think we're pretty much done here.