Line between window title bar and toolbar in standalone window

RESOLVED FIXED in Thunderbird 11.0

Status

Thunderbird
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 11.0
x86_64
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needs tabsontop)

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
Created attachment 582988 [details]
screenshot of the issue

I think this is restricted to the tabs on top patch (bug #644169)
There seems to be a line between the window title bar and the toolbar when you open a message in a new window.
(Assignee)

Updated

6 years ago
Depends on: 644169
(Assignee)

Comment 1

6 years ago
It seems that the only thing I can see differ between standalone window and and the 3pane window is the nodeName mail:messageWindow vs. mail:3pane.

I tried to select this with:
window[windowtype=mail:messageWindow] .mail-toolbox {
  -moz-appearance: toolbox;
}

The css parser did not enjoy that at all.
Then again, it's 3:30 in the morning, so I might be missing something. :)

Comment 2

6 years ago
I think you need quotes around "mail:messageWindow".
(Assignee)

Comment 3

6 years ago
Created attachment 583185 [details] [diff] [review]
patch fixing the issue

The bug is caused by the special toolbar styling we're doing to the main toolbar in 3pane. This patch special-cases the standalone window case.
Attachment #583185 - Flags: ui-review?(bwinton)
Attachment #583185 - Flags: review?(bwinton)
(Assignee)

Comment 4

6 years ago
Created attachment 583209 [details]
screenshot of patch in action
Comment on attachment 583185 [details] [diff] [review]
patch fixing the issue

Review of attachment 583185 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good (modulo the notes below).  r=me.
And the screenshot you posted looks good, except that the lines are missing from the toolbars in the 3-pane, too…  So, uh, I'm not sure what to put for ui-r…

I'll say ui-r=me if the main window still has lines between the toolbars.

::: mail/themes/pinstripe/mail/primaryToolbar.css
@@ -133,4 +141,4 @@
> >    margin: 5px 4px 3px;
> >  }
> >  
> > -#tabbar-toolbar .toolbarbutton-1 {
> > +#tabbar-toolbar > .toolbarbutton-1 {

Is this change (and the previous one) needed to fix the bug, or is it just cleanup suggested by Sid?

@@ -139,4 +147,5 @@
> >    padding-top: 0;
> >    padding-bottom: 0;
> >  }
> >  
> > +

Could we remove this extra line?
Attachment #583185 - Flags: ui-review?(bwinton)
Attachment #583185 - Flags: ui-review+
Attachment #583185 - Flags: review?(bwinton)
Attachment #583185 - Flags: review+
Huh.  As Andreas pointed out on IRC, we don't have the lines between the toolbars in Windows or Linux, or in Firefox on OSX, so removing them here makes sense, too.

Given that, ui-r=me just the way it is.

Thanks,
Blake.
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: needs tabsontop
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/0dd28e137266
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Assignee: nobody → nisses.mail
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 11.0
You need to log in before you can comment on or make changes to this bug.