71243 - all default values for auth_method and try_ssl to be

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[(not reading, please use [e-mail] instead)]

currently, they are hard coded in nsSmtpServer.cpp

we should be respecting the values in mailnews.js, to allow ISPs and IS
departments to configure the defaults (if necessary.)

Comment 1

[Cavin Song]

adding cavin to the cc list.

Comment 2

[(not reading, please use [e-mail] instead)]

re-assigning to cavin.

thanks cavin!

Comment 3

[Cavin Song]

Attachment: patch attach

Comment 4

[(not reading, please use [e-mail] instead)]

comments:

1) 

getDefaultIntPref() should not have a PRBool out parameter.  it should be and
int.  (getDefaultIntPref, not getDefaultBoolPref, right?) 

2)  don't do "nsCOMPtr<nsIPref> &prefs", just do "nsIPref *pref"


so instead of:

nsresult getDefaultIntPref(nsCOMPtr<nsIPref> &prefs, const char *prefName,
PRBool *val);

you should have:

nsresult getDefaultIntPref(nsIPrefs *prefs, const char *prefName, PRInt32 *val);

3)

+  if (NS_FAILED(rv))
+  { // last resort
+    *val = PR_TRUE;
+    rv = NS_OK;
+  }
+  return rv;

since this is an int pref, and not a bool pref, you can't set the last resort
value to be PR_TRUE.

I'd put the last resort (hard coded) logic in the callers.

if you have questions, we can talk about it tomorrow.

Comment 5

[(not reading, please use [e-mail] instead)]

whoops, I meant:

nsresult getDefaultIntPref(const nsIPrefs *prefs, const char *prefName, PRInt32
*val);

Comment 6

[Cavin Song]

Attachment: 2nd Patch file

Comment 7

[(not reading, please use [e-mail] instead)]

r/sr=sspitzer, looks good.

since you don't have CVS access yet, I'll land this patch for you.

Comment 8

[(not reading, please use [e-mail] instead)]

fixed.

nice work cavin.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

For nsSmtpServer.cpp:

1.27 sspitzer%netscape.com Mar 29 21:22 fix for #71243. don't hard code the
default values, get them from the
default prefs. fix by [e-mail]. sr=spitzer

and for nsSmtpServer.h:

1.7 sspitzer%netscape.com Mar 29 21:22 fix for #71243. don't hard code the
default values, get them from the
default prefs. fix by [e-mail]. sr=spitzer

I'm verifying that the code defaults to using the prefs (via a return value
passing parameters, instead of being hard-coded/assigned) in the case of a
'failure'.