712533 - Port |Bug 696159 - Remove some deprecated code from Places| to SeaMonkey

Status: RESOLVED DUPLICATE of bug 1378089

(SeaMonkey :: Bookmarks & History, defect)

Description

[Serge Gautherie (:sgautherie)]

I'm not sure that this is actually related to bug 711937,
but I noticed it in bug 711937 comment 1.

I guess that we want to at least stay in sync' with Firefox, fwiw.
SeaMonkey:
*doesn't use containerOpened() + containerClosed()
*uses showMinimalAddBookmarkUI()
*...

Comment 1

[Serge Gautherie (:sgautherie)]

And would need to port (regression) bug 702081 too.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

There have been reports that the missing functions are actually called:

Error: [Exception... "'JavaScript component does not have a method named: "containerOpened"' when calling method: [nsINavHistoryResultObserver::containerOpened]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: chrome://communicator/content/places/browserPlacesViews.js :: <TOP_LEVEL> :: line 111"  data: no]
Source File: chrome://communicator/content/places/browserPlacesViews.js
Line: 111 -> "this._resultNode.containerOpen = true;"

I didn't check where or whether there are any major implications.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

AFAICS we don't have a bug for the below yet, but maybe it can be fixed here, too:

"start is deprecated and will be removed in a future release. Check the nsILivemarkService interface."
(.../components/nsLivemarkService.js line 201)

"isLivemark is deprecated and will be removed in a future release. Check the nsILivemarkService interface.""
(.../components/nsLivemarkService.js line 201)

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

I guess comment 3 is bug 730837.

Comment 5

[Justin Wood (:Callek)]

No progress here this by the end of this cycle. Not clear to me what the user impact is from reading this bug, punting tracking for next release

Comment 6

[Royce Williams]

(In reply to Justin Wood (:Callek) from comment #5)
> No progress here this by the end of this cycle. Not clear to me what the
> user impact is from reading this bug, punting tracking for next release

The impact is more about development - barring something else being in plaec to ignore the errors, a single tab generates about 200 lines of 'isLivemark is deprecated' errors on my system.

Comment 7

[Frank-Rainer Grahl (:frg)]

For better and/or worse the Library has been ported to 2.53 and up. Should no longer be an issue.