Closed Bug 712533 Opened 12 years ago Closed 4 years ago

Port |Bug 696159 - Remove some deprecated code from Places| to SeaMonkey

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

(seamonkey2.8 wontfix, seamonkey2.9 wontfix, seamonkey2.10 wontfix, seamonkey2.11 wontfix, seamonkey2.12 wontfix, seamonkey2.13 wontfix)

RESOLVED DUPLICATE of bug 1378089
Tracking Status
seamonkey2.8 --- wontfix
seamonkey2.9 --- wontfix
seamonkey2.10 --- wontfix
seamonkey2.11 --- wontfix
seamonkey2.12 --- wontfix
seamonkey2.13 --- wontfix

People

(Reporter: sgautherie, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [2012 Fall Equinox])

I'm not sure that this is actually related to bug 711937,
but I noticed it in bug 711937 comment 1.

I guess that we want to at least stay in sync' with Firefox, fwiw.
SeaMonkey:
*doesn't use containerOpened() + containerClosed()
*uses showMinimalAddBookmarkUI()
*...
And would need to port (regression) bug 702081 too.
Depends on: 702081
Depends on: 713551
No longer blocks: 711937
There have been reports that the missing functions are actually called:

Error: [Exception... "'JavaScript component does not have a method named: "containerOpened"' when calling method: [nsINavHistoryResultObserver::containerOpened]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: chrome://communicator/content/places/browserPlacesViews.js :: <TOP_LEVEL> :: line 111"  data: no]
Source File: chrome://communicator/content/places/browserPlacesViews.js
Line: 111 -> "this._resultNode.containerOpen = true;"

I didn't check where or whether there are any major implications.
AFAICS we don't have a bug for the below yet, but maybe it can be fixed here, too:

"start is deprecated and will be removed in a future release. Check the nsILivemarkService interface."
(.../components/nsLivemarkService.js line 201)

"isLivemark is deprecated and will be removed in a future release. Check the nsILivemarkService interface.""
(.../components/nsLivemarkService.js line 201)
No progress here this by the end of this cycle. Not clear to me what the user impact is from reading this bug, punting tracking for next release
(In reply to Justin Wood (:Callek) from comment #5)
> No progress here this by the end of this cycle. Not clear to me what the
> user impact is from reading this bug, punting tracking for next release

The impact is more about development - barring something else being in plaec to ignore the errors, a single tab generates about 200 lines of 'isLivemark is deprecated' errors on my system.
Whiteboard: [2012 Fall Equinox]

For better and/or worse the Library has been ported to 2.53 and up. Should no longer be an issue.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.