The default bug view has changed. See this FAQ.

Remove MSVC6 support from trace-malloc

VERIFIED FIXED in mozilla14

Status

()

Core
General
--
minor
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
{
/tools/trace-malloc/spacetrace.c
    * line 74 -- ** Ugh, MSVC6's qsort is too slow...
/tools/trace-malloc/spacecategory.c
    * line 56 -- ** Ugh, MSVC6's qsort is too slow...
}

Comment and maybe code should be updated...
(Assignee)

Updated

5 years ago
Whiteboard: [good first bug][mentor=dbaron][lang=c]
(Assignee)

Comment 1

5 years ago
Created attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

http://mxr.mozilla.org/mozilla/source/xpcom/glue/nsQuickSort.h
{
39 /* We need this because Solaris' version of qsort is broken and
40  * causes array bounds reads.
41  */
}

I know nothing about Solaris.
Ftb, it seems the 2 MSVC6 comments should simply be removed.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #608546 - Flags: review?(dbaron)
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

Yeah, comments on why we have or don't have our own qsort probably belong in nsQuickSort.h and not at the callers.
Attachment #608546 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/996b89200406
Attachment #608546 - Attachment description: (Av1) Remove MSVC6 support from trace-malloc → (Av1) Remove MSVC6 support from trace-malloc [Checked in: Comment 3]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=dbaron][lang=c]
Target Milestone: --- → mozilla14
(Assignee)

Comment 4

5 years ago
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.