Last Comment Bug 712552 - Remove MSVC6 support from trace-malloc
: Remove MSVC6 support from trace-malloc
Status: VERIFIED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla14
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks: 508760
  Show dependency treegraph
 
Reported: 2011-12-20 22:08 PST by Serge Gautherie (:sgautherie)
Modified: 2012-03-22 20:45 PDT (History)
1 user (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
(Av1) Remove MSVC6 support from trace-malloc [Checked in: Comment 3] (1.23 KB, patch)
2012-03-22 17:46 PDT, Serge Gautherie (:sgautherie)
dbaron: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2011-12-20 22:08:36 PST
{
/tools/trace-malloc/spacetrace.c
    * line 74 -- ** Ugh, MSVC6's qsort is too slow...
/tools/trace-malloc/spacecategory.c
    * line 56 -- ** Ugh, MSVC6's qsort is too slow...
}

Comment and maybe code should be updated...
Comment 1 Serge Gautherie (:sgautherie) 2012-03-22 17:46:34 PDT
Created attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

http://mxr.mozilla.org/mozilla/source/xpcom/glue/nsQuickSort.h
{
39 /* We need this because Solaris' version of qsort is broken and
40  * causes array bounds reads.
41  */
}

I know nothing about Solaris.
Ftb, it seems the 2 MSVC6 comments should simply be removed.
Comment 2 David Baron :dbaron: ⌚️UTC+2 (mostly busy through August 4; review requests must explain patch) 2012-03-22 18:14:53 PDT
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

Yeah, comments on why we have or don't have our own qsort probably belong in nsQuickSort.h and not at the callers.
Comment 3 Serge Gautherie (:sgautherie) 2012-03-22 19:00:01 PDT
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/996b89200406
Comment 4 Serge Gautherie (:sgautherie) 2012-03-22 20:45:38 PDT
V.Fixed, per MXR search.

Note You need to log in before you can comment on or make changes to this bug.