Closed Bug 712552 Opened 8 years ago Closed 8 years ago

Remove MSVC6 support from trace-malloc

Categories

(Core :: General, defect, minor)

defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla14

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file)

{
/tools/trace-malloc/spacetrace.c
    * line 74 -- ** Ugh, MSVC6's qsort is too slow...
/tools/trace-malloc/spacecategory.c
    * line 56 -- ** Ugh, MSVC6's qsort is too slow...
}

Comment and maybe code should be updated...
Whiteboard: [good first bug][mentor=dbaron][lang=c]
http://mxr.mozilla.org/mozilla/source/xpcom/glue/nsQuickSort.h
{
39 /* We need this because Solaris' version of qsort is broken and
40  * causes array bounds reads.
41  */
}

I know nothing about Solaris.
Ftb, it seems the 2 MSVC6 comments should simply be removed.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #608546 - Flags: review?(dbaron)
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

Yeah, comments on why we have or don't have our own qsort probably belong in nsQuickSort.h and not at the callers.
Attachment #608546 - Flags: review?(dbaron) → review+
Comment on attachment 608546 [details] [diff] [review]
(Av1) Remove MSVC6 support from trace-malloc
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/996b89200406
Attachment #608546 - Attachment description: (Av1) Remove MSVC6 support from trace-malloc → (Av1) Remove MSVC6 support from trace-malloc [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=dbaron][lang=c]
Target Milestone: --- → mozilla14
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.