Remove MSVC6 support from Cairo Readme

VERIFIED FIXED in mozilla13

Status

()

Core
Graphics
--
trivial
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: pallavi)

Tracking

Trunk
mozilla13
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
{
/gfx/cairo/README
    * line 15 -- VC6 is not supported. Please upgrade to VC8.
}

If I'm not mistaken, VC8 is (now) the lowest supported version in m-c anyway.
Flags: in-testsuite-
I don't understand this bug. README says VC6 is not supported which is true. Do you just want the reference removed?
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 2

6 years ago
(In reply to Benoit Girard (:BenWa) from comment #1)
> Do you just want the reference removed?

Yes, I think this sentence doesn't have much value now.
(Assignee)

Comment 3

5 years ago
Created attachment 604005 [details] [diff] [review]
The reference line to MSVC6 has been removed
Attachment #604005 - Flags: review?(sgautherie.bz)
(Reporter)

Updated

5 years ago
Attachment #604005 - Flags: review?(sgautherie.bz) → review?(jmuizelaar)
Attachment #604005 - Flags: review?(jmuizelaar) → review+
(Reporter)

Comment 4

5 years ago
Please attach a patch according to
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Assignee: nobody → pallavikumarijha
Status: NEW → ASSIGNED
(Assignee)

Comment 5

5 years ago
Created attachment 604613 [details] [diff] [review]
patch5
Attachment #604005 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #4)
> Please attach a patch according to
> https://developer.mozilla.org/en/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F

I made the patch according to the described formate,but while attaching it there was no option for requestee so its coming without flag is it fine?
(Reporter)

Comment 7

5 years ago
(In reply to pallavi from comment #6)

> I made the patch according to the described formate,but while attaching it

No, it still misses author and description.

> there was no option for requestee so its coming without flag is it fine?

See
https://developer.mozilla.org/En/Developer_Guide/How_to_Submit_a_Patch#Committing_the_patch
I tried to guess the field from your email, I hope I got it right.

Congrats on your first check-in, it should be in the main branch within a 24 hours:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bb28e575749
(Assignee)

Comment 9

5 years ago
thank you :),but according to comment 7 it was missing some criteria right?
It was just referring to a description and author field for the commit. The only way I know how to do this is mercurial queues but no need to use it until you start building more complex changesets.

https://developer.mozilla.org/en/Mercurial_Queues
https://hg.mozilla.org/mozilla-central/rev/5bb28e575749
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
(Reporter)

Comment 12

5 years ago
V.Fixed, per MXR search.


(In reply to Benoit Girard (:BenWa) from comment #10)
> It was just referring to a description and author field for the commit. The
> only way I know how to do this is mercurial queues but no need to use it
> until you start building more complex changesets.

Ftr, mq is quite easy to use.
And patches can always be manually edited.
Status: RESOLVED → VERIFIED
Whiteboard: [good first bug]
You need to log in before you can comment on or make changes to this bug.