The default bug view has changed. See this FAQ.

libffi fails to build on mingw-w64

RESOLVED FIXED in mozilla12

Status

()

Core
js-ctypes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
It fails after ABI change made for MSVC compatibility. I've fixed the problem upstream a while ago:

https://github.com/atgreen/libffi/commit/ba022c338af97cb18d9f8ed5a607fd483a61c09c

Since there are no plans to merge recent libffi anytime soon AFAIK, I will attach a backport of upstream patch.
(Assignee)

Comment 1

5 years ago
Created attachment 583440 [details] [diff] [review]
fix
Attachment #583440 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #583440 - Flags: review? → review?(benjamin)
Attachment #583440 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff350b65a616
Whiteboard: [inbound]
(Assignee)

Comment 3

5 years ago
Backed out due to Adroid compilation failure:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e88517446ab2
Whiteboard: [inbound]
(Assignee)

Comment 4

5 years ago
It looks like the failure was unrelated. I will run this through try again before landing.
(Assignee)

Comment 5

5 years ago
Try succeeded, it looks like clobbering was needed due to configure changes. Pushed with clobbered Android builds:

https://hg.mozilla.org/integration/mozilla-inbound/rev/90a869f23e11
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/90a869f23e11
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Created attachment 653177 [details] [diff] [review]
properly regen configure

Let's properly regen configure with autoconf since lines changed, see bug 670719 comment 52
Attachment #653177 - Flags: review?(mh+mozilla)
Comment on attachment 653177 [details] [diff] [review]
properly regen configure

Review of attachment 653177 [details] [diff] [review]:
-----------------------------------------------------------------

Let's do that in a separate bug
Attachment #653177 - Flags: review?(mh+mozilla) → review-
Comment on attachment 653177 [details] [diff] [review]
properly regen configure

Discard, superseded by bug 783950
Attachment #653177 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.