Closed Bug 712594 Opened 8 years ago Closed 8 years ago

libffi fails to build on mingw-w64

Categories

(Core :: js-ctypes, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: [inbound])

Attachments

(1 file, 1 obsolete file)

It fails after ABI change made for MSVC compatibility. I've fixed the problem upstream a while ago:

https://github.com/atgreen/libffi/commit/ba022c338af97cb18d9f8ed5a607fd483a61c09c

Since there are no plans to merge recent libffi anytime soon AFAIK, I will attach a backport of upstream patch.
Attached patch fixSplinter Review
Attachment #583440 - Flags: review?
Attachment #583440 - Flags: review? → review?(benjamin)
Attachment #583440 - Flags: review?(benjamin) → review+
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff350b65a616
Whiteboard: [inbound]
Backed out due to Adroid compilation failure:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e88517446ab2
Whiteboard: [inbound]
It looks like the failure was unrelated. I will run this through try again before landing.
Try succeeded, it looks like clobbering was needed due to configure changes. Pushed with clobbered Android builds:

https://hg.mozilla.org/integration/mozilla-inbound/rev/90a869f23e11
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/90a869f23e11
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Attached patch properly regen configure (obsolete) — Splinter Review
Let's properly regen configure with autoconf since lines changed, see bug 670719 comment 52
Attachment #653177 - Flags: review?(mh+mozilla)
Comment on attachment 653177 [details] [diff] [review]
properly regen configure

Review of attachment 653177 [details] [diff] [review]:
-----------------------------------------------------------------

Let's do that in a separate bug
Attachment #653177 - Flags: review?(mh+mozilla) → review-
Comment on attachment 653177 [details] [diff] [review]
properly regen configure

Discard, superseded by bug 783950
Attachment #653177 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.