Make Wifi work under gonk

RESOLVED FIXED in mozilla12

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla12
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 583477 [details] [diff] [review]
wip patch

Here's a patch to Gecko that seems to work under gonk. There's still some unexplained business on my phone where I'm not sure why wifi seemed to magically start working. I'm going to see if this works on other phones and if not, I'll debug further.
Attachment #583477 - Flags: review?(gal)
(Assignee)

Comment 1

6 years ago
Created attachment 584443 [details] [diff] [review]
wip patch

With this patch we connect to a hardcoded network and properly bring up dhcp and dns. There's pretty clearly a bunch of refactoring/cleaning up to do, but this actually appears to work.
Attachment #583477 - Attachment is obsolete: true
Attachment #583477 - Flags: review?(gal)
Attachment #584443 - Flags: review?(gal)

Comment 2

6 years ago
Comment on attachment 584443 [details] [diff] [review]
wip patch

Review of attachment 584443 [details] [diff] [review]:
-----------------------------------------------------------------

Looks very nice. Lets land this and we can work on the high-level wifi control next (look for configured available networks, associated in order, see if we have a connection, if not move to the next, keep pinging network to make sure its available, if not reconfigure, etc). We should file a bug for that. We also need a DOM API for editing networks and wifi on/off (bug for that too?).

::: dom/system/b2g/RadioManager.cpp
@@ +253,5 @@
>    NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");
>  
>    StopRil();
>    mTelephone = nsnull;
> +  mWifi = nsnull;

RadioManager isn't the best name for this class any more. We should rename it down the road.
Attachment #584443 - Flags: review?(gal) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 584443 [details] [diff] [review]
wip patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a498f3bae5c

Bug 711671 covers the renaming you talked about.
Attachment #584443 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/8a498f3bae5c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Where's the followup work for this being tracked?  Part of the "network manager", bug 713199 and bug 697355, or something else?
Blocks: 713199
Blocks: 697355
Blocks: 717122
Blocks: 717123
No longer blocks: 697355
No longer blocks: 717122

Updated

5 years ago
Blocks: 729877
No longer blocks: 729877
You need to log in before you can comment on or make changes to this bug.