Last Comment Bug 712629 - Make Wifi work under gonk
: Make Wifi work under gonk
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: unspecified
: ARM Android
-- normal (vote)
: mozilla12
Assigned To: Blake Kaplan (:mrbkap)
: Andrew Overholt [:overholt]
Depends on:
Blocks: 713199 b2g-wifi
  Show dependency treegraph
Reported: 2011-12-21 06:35 PST by Blake Kaplan (:mrbkap)
Modified: 2012-02-23 03:39 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

wip patch (53.37 KB, patch)
2011-12-21 06:35 PST, Blake Kaplan (:mrbkap)
no flags Details | Diff | Splinter Review
wip patch (56.45 KB, patch)
2011-12-27 08:40 PST, Blake Kaplan (:mrbkap)
gal: review+
mrbkap: checkin+
Details | Diff | Splinter Review

Description User image Blake Kaplan (:mrbkap) 2011-12-21 06:35:35 PST
Created attachment 583477 [details] [diff] [review]
wip patch

Here's a patch to Gecko that seems to work under gonk. There's still some unexplained business on my phone where I'm not sure why wifi seemed to magically start working. I'm going to see if this works on other phones and if not, I'll debug further.
Comment 1 User image Blake Kaplan (:mrbkap) 2011-12-27 08:40:01 PST
Created attachment 584443 [details] [diff] [review]
wip patch

With this patch we connect to a hardcoded network and properly bring up dhcp and dns. There's pretty clearly a bunch of refactoring/cleaning up to do, but this actually appears to work.
Comment 2 User image Andreas Gal :gal 2011-12-27 12:32:33 PST
Comment on attachment 584443 [details] [diff] [review]
wip patch

Review of attachment 584443 [details] [diff] [review]:

Looks very nice. Lets land this and we can work on the high-level wifi control next (look for configured available networks, associated in order, see if we have a connection, if not move to the next, keep pinging network to make sure its available, if not reconfigure, etc). We should file a bug for that. We also need a DOM API for editing networks and wifi on/off (bug for that too?).

::: dom/system/b2g/RadioManager.cpp
@@ +253,5 @@
>    NS_ASSERTION(NS_IsMainThread(), "Wrong thread!");
>    StopRil();
>    mTelephone = nsnull;
> +  mWifi = nsnull;

RadioManager isn't the best name for this class any more. We should rename it down the road.
Comment 3 User image Blake Kaplan (:mrbkap) 2011-12-28 06:25:25 PST
Comment on attachment 584443 [details] [diff] [review]
wip patch

Bug 711671 covers the renaming you talked about.
Comment 4 User image Marco Bonardo [::mak] 2011-12-29 03:17:37 PST
Comment 5 User image Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-01-05 19:14:40 PST
Where's the followup work for this being tracked?  Part of the "network manager", bug 713199 and bug 697355, or something else?

Note You need to log in before you can comment on or make changes to this bug.