712682 - Add-on ownership changes need to be indicated to reviewers / admins

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

We've occasionally had problems with add-ons that change hands and make radical updates that can be harmful to users. We need a way to keep track of these changes so that we can pay special attention to future releases of those add-ons.

Discussing this with fligtar, there are 2 ways to keep track of this, both of which I think should be implemented:

1) Whenever a an owner or developer is added or removed from an add-on, send a message to amo-admins, similar to the one currently being sent for add-ons being deleted.

2) Show these ownership changes in the Add-on History section of review pages.

Comment 1

[Wil Clouser [:clouserw]]

> 1) Whenever a an owner or developer is added or removed from an add-on, send
> a message to amo-admins, similar to the one currently being sent for add-ons
> being deleted.

Bug 674642 would solve this problem without email, I think.  Would you still want email?

> 2) Show these ownership changes in the Add-on History section of review
> pages.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Wil Clouser [:clouserw] from comment #1)
> > 1) Whenever a an owner or developer is added or removed from an add-on, send
> > a message to amo-admins, similar to the one currently being sent for add-ons
> > being deleted.
> 
> Bug 674642 would solve this problem without email, I think.  Would you still
> want email?

Yes, we want to be notified about this.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Resetting a bunch of missed milestones. Sorry for the bugspam.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

So, for this, we want to note any ownership changes in the review log of the add-on, so that reviewers can take it into account. I don't think sending e-mail is necessary for this.

Comment 6

[Wil Clouser [:clouserw]]

It's been noted in another bug that authors aren't notified either.  Perhaps we should email the new (and old?) owners as well?

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Notifying current and new owners would be good.

Comment 8

[Wil Clouser [:clouserw]]

Ok, so to fix this bug we want:

1) Log any ownership changes to the review log of the add-on
2) Email the owner that a new person was added as an author of their add-on
3) Email the new owner that they have been added as an author of the add-on

Jorge or I can help you with copy for the emails if you need it.  Thanks.

Comment 10

[Ignacio Garrido]

Remember that this should be applied in Collections as well and IMHO a confirmation should be required.

Regards,

Ignacio.

Comment 11

[Wil Clouser [:clouserw]]

(In reply to Ignacio Garrido from comment #10)
> Remember that this should be applied in Collections as well and IMHO a
> confirmation should be required.

Thanks, but that will be out of scope for this bug.  Comment 8 is what we need to close this.

Comment 12

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/405

Comment 13

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/8cdeeef902ae2da0827505566f80ea397ca217dd

Comment 14

[Victor Carciu]

The emails are received , but they are not formatted : http://screencast.com/t/wfLJ42fK

Comment 15

[Mathieu Agopian [:magopian]]

Fix emails in https://github.com/mozilla/olympia/pull/411

Comment 16

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/e3a441dc401dcd7ac65140a32639e08801506856