712687 - [ICS] Landscape should use a different layout

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Sriram Ramasubramanian [:sriram]]

The height of actionbar in landscape in ICS is just 40dp, the UI should be optimized for it. A new folder layout-land-v14/ is needed to match the landscape specific UI.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: WIP

This WIP is almost close (until I saw Gingerbread :( ). It is pixel perfect on ICS.
The gingerbread is having few issues - basically due to a slight difference in the curvature and a font differences.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Screenshot: Gingerbread with the url bar changes

This is a screenshot of the URL bar with the changes in Gingerbread.

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://cl.ly/0m3d1K3O3S0W2F3w1432 -- This holds the spec as provided by Ian.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 583658 [details] [diff] [review]
WIP

The comment about Gingerbread is making me wonder if this patch is ready for review:
* Will this patch fix ICS only?
* Do we need another patch for Gingerbread?

Comment 5

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

With new set of resources, this patch finally addresses gingerbread and ics properly. The font-size is made to be different for gingerbread (droid-sans) and ics (roboto) so that it stays on top of the arrow mark.

Comment 6

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7d5a6dae7d76

Comment 7

[Joe Drew (not getting mail)]

https://hg.mozilla.org/mozilla-central/rev/7d5a6dae7d76

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Sriram, please request approval for aurora

Comment 9

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 591950 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: 
The ICS will have a broken UI (in terms of UI polishing). It's better to have this UI as this is the latest as per UX team's design.

Testing completed (on m-c, etc.): Landed on m-c on 01/28
Testing done on the following devices:
1. Samsung S II (hdpi device running gingerbread)
2. Nexus S (hdpi device running ICS)
3. Galaxy Nexus (xhdpi device running ICS)
4. Samsung Galaxy Tab 10.1 (mdpi device running honeycomb)

Risk to taking this patch (and alternatives if risky):
This patch is not risky and wouldn't break anything existing as it is just replacing newer resources and fixing few pixels in the layout based on newer resources.

Comment 10

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 591950 [details] [diff] [review]
Patch

[Approval Request Comment]
User impact if declined: This bug has a more polished UI than what is currently available in beta build.

Risk to taking this patch (and alternatives if risky):
Risk is none as there are changes to UI layout only.

String changes made by this patch: None.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 591950 [details] [diff] [review]
Patch

[Triage Comment]
Mobile only - approved for Beta 11.

Comment 12

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/24b174ae0d99

Comment 13

[Matt Brubeck (:mbrubeck)]

Comment on attachment 591950 [details] [diff] [review]
Patch

Clearing approval for Aurora 12 and Beta 11 because we are not currently planning a Native Fennec release of these versions.  If this changes in the future, we will likely do a mass uplift of all native fennec changes.  For now, let's get these bugs off the channel triage radar.

[Filter on the string "mbrubeck-bugspam" if you want to delete all of these emails at once.]

Comment 14

[Nick Alexander :nalexander [he/him]]

sriram, can you help me understand what is going on with

mobile/android/base/resources/drawable/tabs_button_tail.xml

It appears to be deleted in a merge commit:

http://hg.mozilla.org/integration/mozilla-inbound/rev/c4c50dc6317c#l366.1

Can you verify it is correctly referenced in

mobile/android/base/resources/drawable/gecko_actionbar_bg.xml

Does this need to be fixed?

Comment 15

[Sriram Ramasubramanian [:sriram]]

(In reply to Nick Alexander :nalexander from comment #14)
> sriram, can you help me understand what is going on with
> 
> mobile/android/base/resources/drawable/tabs_button_tail.xml
> 
> It appears to be deleted in a merge commit:
> 
> http://hg.mozilla.org/integration/mozilla-inbound/rev/c4c50dc6317c#l366.1
> 
> Can you verify it is correctly referenced in
> 
> mobile/android/base/resources/drawable/gecko_actionbar_bg.xml
> 
> Does this need to be fixed?

There is some piece of junk code residing in our code base. We need to clean that up. They are not in the Makefile.in This was used to show a tail behind the menu button (long long ago). Please file a bug. I'll clean this up.