Closed
Bug 712837
Opened 13 years ago
Closed 13 years ago
Fix flakey jstest js1_5/extensions/regress-371636.js
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
4.75 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
In the test js1_5/extensions/regress-371636.js, we time a loop over an Array using Numbers as keys, then do the same loop again using Strings as keys. The test asserts that the time using Strings is less than 3 times as large as the time using Numbers. Naturally, when running the tests with high parallelism, this tends to fail at random.
This test is current marked as 'random-if(xulRuntime.OS=="WINNT") bug 528284', but I don't think this tests anything at all useful, so we should just remove it.
Attachment #583693 -
Flags: review?(dmandelin)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 583693 [details] [diff] [review]
v1
Review of attachment 583693 [details] [diff] [review]:
-----------------------------------------------------------------
Yeah, I don't like these tests. They should just be automated benchmarks for the cases where we care a lot.
Attachment #583693 -
Flags: review?(dmandelin) → review+
|
||
Comment 2•13 years ago
|
||
Worth adding as a dependency to 467263?
|
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•