Last Comment Bug 712837 - Fix flakey jstest js1_5/extensions/regress-371636.js
: Fix flakey jstest js1_5/extensions/regress-371636.js
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Terrence Cole [:terrence]
:
:
Mentors:
Depends on:
Blocks: 528284
  Show dependency treegraph
 
Reported: 2011-12-21 17:54 PST by Terrence Cole [:terrence]
Modified: 2011-12-26 17:59 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (4.75 KB, patch)
2011-12-21 17:54 PST, Terrence Cole [:terrence]
dmandelin: review+
Details | Diff | Splinter Review

Description Terrence Cole [:terrence] 2011-12-21 17:54:34 PST
Created attachment 583693 [details] [diff] [review]
v1

In the test js1_5/extensions/regress-371636.js, we time a loop over an Array using Numbers as keys, then do the same loop again using Strings as keys.  The test asserts that the time using Strings is less than 3 times as large as the time using Numbers.  Naturally, when running the tests with high parallelism, this tends to fail at random.

This test is current marked as 'random-if(xulRuntime.OS=="WINNT") bug 528284', but I don't think this tests anything at all useful, so we should just remove it.
Comment 1 David Mandelin [:dmandelin] 2011-12-21 18:16:00 PST
Comment on attachment 583693 [details] [diff] [review]
v1

Review of attachment 583693 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I don't like these tests. They should just be automated benchmarks for the cases where we care a lot.
Comment 2 Ryan VanderMeulen [:RyanVM] 2011-12-21 18:18:01 PST
Worth adding as a dependency to 467263?
Comment 3 Ed Morley [:emorley] 2011-12-26 17:59:27 PST
https://hg.mozilla.org/mozilla-central/rev/8eb78de9abf4

Note You need to log in before you can comment on or make changes to this bug.