The default bug view has changed. See this FAQ.

Fix flakey jstest js1_5/extensions/regress-371636.js

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 583693 [details] [diff] [review]
v1

In the test js1_5/extensions/regress-371636.js, we time a loop over an Array using Numbers as keys, then do the same loop again using Strings as keys.  The test asserts that the time using Strings is less than 3 times as large as the time using Numbers.  Naturally, when running the tests with high parallelism, this tends to fail at random.

This test is current marked as 'random-if(xulRuntime.OS=="WINNT") bug 528284', but I don't think this tests anything at all useful, so we should just remove it.
Attachment #583693 - Flags: review?(dmandelin)
Comment on attachment 583693 [details] [diff] [review]
v1

Review of attachment 583693 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I don't like these tests. They should just be automated benchmarks for the cases where we care a lot.
Attachment #583693 - Flags: review?(dmandelin) → review+
Worth adding as a dependency to 467263?
Blocks: 528284
https://hg.mozilla.org/mozilla-central/rev/8eb78de9abf4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.