Convert existing JS_STATIC_ASSERT users to static_assert
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
References
Details
(Whiteboard: [lang=c++])
Attachments
(16 files)
209.32 KB,
patch
|
Details | Diff | Splinter Review | |
2.48 KB,
patch
|
BenWa
:
review+
mccr8
:
review+
benjamin
:
review+
|
Details | Diff | Splinter Review |
10.61 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
12.15 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
7.89 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
3.13 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
4.84 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
17.16 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
5.45 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
![]() |
||
Comment 3•14 years ago
|
||
Assignee | ||
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Updated•13 years ago
|
Updated•12 years ago
|
Comment 6•12 years ago
|
||
Comment 8•12 years ago
|
||
Assignee | ||
Comment 9•12 years ago
|
||
Assignee | ||
Comment 10•12 years ago
|
||
Comment 11•11 years ago
|
||
Comment 12•11 years ago
|
||
![]() |
||
Comment 13•11 years ago
|
||
Comment 14•11 years ago
|
||
![]() |
||
Comment 15•11 years ago
|
||
Comment 16•11 years ago
|
||
Comment 17•11 years ago
|
||
Comment 18•11 years ago
|
||
Comment 19•11 years ago
|
||
Comment 20•11 years ago
|
||
Comment 21•11 years ago
|
||
Comment 22•11 years ago
|
||
Comment 23•11 years ago
|
||
Comment 24•11 years ago
|
||
Updated•11 years ago
|
Comment 25•11 years ago
|
||
Comment 26•11 years ago
|
||
Assignee | ||
Comment 28•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Comment 29•11 years ago
|
||
Assignee | ||
Comment 30•11 years ago
|
||
Comment 31•11 years ago
|
||
Assignee | ||
Comment 32•11 years ago
|
||
Comment 33•11 years ago
|
||
Assignee | ||
Comment 34•11 years ago
|
||
Assignee | ||
Comment 35•11 years ago
|
||
Assignee | ||
Comment 36•11 years ago
|
||
Assignee | ||
Comment 37•11 years ago
|
||
Assignee | ||
Comment 38•11 years ago
|
||
Comment 39•11 years ago
|
||
Comment 40•11 years ago
|
||
Updated•11 years ago
|
Comment 41•11 years ago
|
||
Comment 42•11 years ago
|
||
Assignee | ||
Comment 43•11 years ago
|
||
Comment 44•11 years ago
|
||
Comment 45•7 years ago
|
||
Assignee | ||
Comment 46•7 years ago
|
||
Comment 47•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:sdetar, maybe it's time to close this bug?
Comment 48•6 years ago
|
||
Jeff, is comment 46 still true, should we continue to leave this open?
![]() |
||
Comment 49•6 years ago
|
||
grep tells me there are still over 100 JS_STATIC_ASSERT
s.
Comment 50•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:Waldo, maybe it's time to close this bug?
Comment 51•6 years ago
|
||
Waldo, do you think it's okay to simply change the remaining JS_STATIC_ASSERT
to static_assert
without adding the message argument (which is now possible because we compile with C++17)? It'd still be nice to have a message argument for every static_assert
, but that could be done in a follow-up bug.
Comment 52•5 years ago
|
||
Comment 53•5 years ago
|
||
Depends on D62272
Comment 54•5 years ago
|
||
Depends on D62273
Comment 55•5 years ago
|
||
Depends on D62275
Comment 56•5 years ago
|
||
Depends on D62276
Comment 57•5 years ago
|
||
Depends on D62277
Comment 58•5 years ago
|
||
Depends on D62278
Comment 59•5 years ago
|
||
Updated•5 years ago
|
Comment 60•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f6a2c77cb391
https://hg.mozilla.org/mozilla-central/rev/2e52b55868b6
https://hg.mozilla.org/mozilla-central/rev/8d49af1ca9a9
https://hg.mozilla.org/mozilla-central/rev/ef2c8d887a50
https://hg.mozilla.org/mozilla-central/rev/d1ba08b70980
https://hg.mozilla.org/mozilla-central/rev/7a878990c1bb
https://hg.mozilla.org/mozilla-central/rev/cd2a1604e576
Assignee | ||
Updated•5 years ago
|
Description
•