712972 - Can't type mzl.la into awesome bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

I can't type mzl.la into the awesome bar. After I type "mzl.", when I click the next "l" the awesome bar drops the "mzl." portion (so I just see "l"). I see the same behaviour if I type "http:" when I next click "/" the "http:" portion is dropped from the awesome bar leaving just "/".

Comment 1

[Cristian Nicolae (:xti)]

It works fine for me on the latest Nightly build.

--
Mozilla/5.0 (Android;Linux armv7l;rv:12.0a1)Gecko/20111222
Firefox/12.0a1 Fennec/12.0a1
Devices: Samsung Galaxy S
OS: Android 2.2

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

I just updated to 20111222 and still no joy.

build: 20111222
Device: Samsung Galaxy S II
OS: Android 2.3.4
keyboard: Swype

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

Oh, I see this on both Nightly and Aurora 20111222.

Comment 4

[Cristian Nicolae (:xti)]

(In reply to Lawrence Mandel [:lmandel] from comment #3)
> Oh, I see this on both Nightly and Aurora 20111222.

I've tried both with Android Keyboard and Swipe and it's still working fine for my device. We need to see what's happening here. Could you upload a video about your performing steps please? It might be helpful

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Here's a video (sorry about the quality) that shows the issue.

http://www.youtube.com/watch?v=XNavZVJOnN8

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Lawrence, what keyboard are you using?

Comment 7

[Aaron Train [:aaronmt]]

(In reply to Brad Lassey [:blassey] from comment #6)
> Lawrence, what keyboard are you using?

Comment #2 says Swype. I have the exact same phone, OS, keyboard and don't see this.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Yes. Using Swype, which came installed on the phone. I also tried clearing the data for Aurora and restarting but have the same results.

Comment 9

[Alex Pakhotin (:alexp)]

I see this behavior on a Galaxy Tab 10.1 with pre-installed Swype v.3.25.91.34889 and Nexus One with Swype v.3.25.91D.31083, but no such problem on Droid 3 with Swype v.3.25.91.30214.30244.
Doesn't happen with other IMEs either.

Comment 10

[Alex Pakhotin (:alexp)]

This is caused by the way how Swype handles auto-completion. It is treating "mzl." string as a text to be replaced with a suggestion, and when the "l" is entered it decides to replace the text with an empty string (as there are no better suggestions). I'm going to disable suggestions for the URL, which will fix this issue.

Comment 11

[Alex Pakhotin (:alexp)]

Attachment: Fix

Disable suggestions for the AwesomeBar edit field.

I tried to modify this parameter dynamically, so that when the AwesomeBar is in the Search mode, the suggestions were still made, but it doesn't seem to work when changed on the fly, so for now it's just a static unconditional disabling.

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Madhava, this patch will disable all IME suggestions in the url and search bar. Is this ok with UX?

Comment 15

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This works fine in the stock browser on my Galaxy S II: the input isn't eaten and I get autocompletion suggestions on elements of domain names.  That said, I can't really think of when I've found domain-name-component autocompletion particularly useful.

Comment 16

[Peter Retzer (:pretzer)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #15)
 
> That said, I can't really think of when I've found domain-name-component
> autocompletion particularly useful.

But for searching it might be useful, which would be impacted by this as well, right?

Comment 17

[Alex Pakhotin (:alexp)]

(In reply to pretzer from comment #16)
> > That said, I can't really think of when I've found domain-name-component
> > autocompletion particularly useful.
> 
> But for searching it might be useful, which would be impacted by this as
> well, right?

Right - that's why we want UX confirmation.

Comment 18

[aja+bugzilla]

FYI: disabling "Word suggestion" in Swype settings bypasses the problem for me.

Comment 19

[Alex Pakhotin (:alexp)]

(In reply to aja+bugzilla from comment #18)
> FYI: disabling "Word suggestion" in Swype settings bypasses the problem for
> me.

You mentioned on IRC it started misbehaving for you just 2-3 days ago. Can you actually confirm it? This bug has been around for quite a while, and I don't think anything has changed since it was found.
I am asking just in a hope to find a cause, which might affect the behavior.

Comment 20

[Alex Pakhotin (:alexp)]

As agreed with Madhava on IRC, we should push this fix, but follow up in the bug 719527 to re-enable the input suggestions for Search mode.

One more consideration to take into account. Many IMEs do not suggest words in the AwesomeBar anyway. That includes the standard Android keyboard, Motorola Multi-touch keyboard, Swiftkey X, and some others, so the actual number of users affected by this change is not that huge.

Comment 21

[Alex Pakhotin (:alexp)]

Attachment: Fix (updated)

Updated the fix.

Comment 22

[Alex Pakhotin (:alexp)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ffb74dfed7c

Comment 23

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7ffb74dfed7c

Comment 24

[Alex Pakhotin (:alexp)]

Comment on attachment 589940 [details] [diff] [review]
Fix (updated)

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Impossible to type URLs in Awesomebar with Swype
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Low

Comment 25

[Alex Keybl [:akeybl]]

Comment on attachment 589940 [details] [diff] [review]
Fix (updated)

[Triage Comment]
Mobile only - approved for Aurora.

Comment 26

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1e16e533aea

Comment 27

[Catalin Suciu [:csuciu]]

I cannot reproduce this issue on Nightly 13.0a1 (2012-02-01)
                                 Aurora  11.0a2 (2012-02-01)
Device: Samsung Galaxy S II
OS: Android 2.3.4
keyboard: Swype

Verifying.