Status
People
(Reporter: Paenglab, Assigned: Paenglab)
Tracking
Thunderbird Tracking Flags
(thunderbird11 fixed)
Details
Attachments
(2 attachments, 1 obsolete attachment)
73.39 KB,
image/png
|
Details | |
1008 bytes,
patch
|
Paenglab
:
review+
Paenglab
:
ui-review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
The Box moving in Bug 644169 moved in standalone window the window shadow border below the toolbars.
(Assignee) | ||
Comment 1•7 years ago
|
||
Created attachment 583888 [details] [diff] [review] Standalone window patch Patch to fix this issue
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #583888 -
Flags: ui-review?(bwinton)
Attachment #583888 -
Flags: review?(bwinton)
(Assignee) | ||
Comment 2•7 years ago
|
||
Created attachment 583909 [details] Comparison with before and after the patch
Comment 3•7 years ago
|
||
Comment on attachment 583888 [details] [diff] [review] Standalone window patch Looks better in the standalone window, so ui-r=me. >+++ b/mail/themes/qute/mail/messageWindow-aero.css >@@ -54,8 +54,22 @@ >+ #messengerWindow[sizemode=normal] #navigation-toolbox { I don't see any other occurrences of "navigation-toolbox" in the code… Does this rule actually do anything? >+ #messengerWindow[sizemode=normal] #mail-toolbox { >+ border-left: 1px solid rgba(10%, 10%, 10%, .4); >+ border-right: 1px solid rgba(10%, 10%, 10%, .4); >+ background-clip: padding-box; >+ } >+ > #messengerWindow[sizemode=normal] #messagepanebox { > border: 1px solid rgba(10%, 10%, 10%, .4); >+ border-top: none; > background-clip: padding-box; > } I wonder if there's not a better way to do that, since they're so similar… Something like: #messengerWindow[sizemode=normal] #mail-toolbox, #messengerWindow[sizemode=normal] #messagepanebox { border: 1px solid rgba(10%, 10%, 10%, .4); border-top: none; background-clip: padding-box; } #messengerWindow[sizemode=normal] #mail-toolbox { border-bottom: none; } That way we don't have the re-duplication of the border… So, I guess I found a few things I'ld like changed, but they're pretty simple, so I'm going to say r=me with them changed. Thanks, Blake.
Attachment #583888 -
Flags: ui-review?(bwinton)
Attachment #583888 -
Flags: ui-review+
Attachment #583888 -
Flags: review?(bwinton)
Attachment #583888 -
Flags: review+
(Assignee) | ||
Comment 4•7 years ago
|
||
Created attachment 584078 [details] [diff] [review] Standalone window patch for check-in (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #3) > Comment on attachment 583888 [details] [diff] [review] > Standalone window patch > > Looks better in the standalone window, so ui-r=me. > > >+++ b/mail/themes/qute/mail/messageWindow-aero.css > >@@ -54,8 +54,22 @@ > >+ #messengerWindow[sizemode=normal] #navigation-toolbox { > > I don't see any other occurrences of "navigation-toolbox" in the code… Does > this rule actually do anything? This code makes the border around the menubar. "navigation-toolbox" is also in primaryToolbar-aero.css at line 51, 93, 290 and 296. > >+ #messengerWindow[sizemode=normal] #mail-toolbox { > >+ border-left: 1px solid rgba(10%, 10%, 10%, .4); > >+ border-right: 1px solid rgba(10%, 10%, 10%, .4); > >+ background-clip: padding-box; > >+ } > >+ > > #messengerWindow[sizemode=normal] #messagepanebox { > > border: 1px solid rgba(10%, 10%, 10%, .4); > >+ border-top: none; > > background-clip: padding-box; > > } > > I wonder if there's not a better way to do that, since they're so similar… > Something like: > > #messengerWindow[sizemode=normal] #mail-toolbox, > #messengerWindow[sizemode=normal] #messagepanebox { > border: 1px solid rgba(10%, 10%, 10%, .4); > border-top: none; > background-clip: padding-box; > } > > #messengerWindow[sizemode=normal] #mail-toolbox { > border-bottom: none; > } > > That way we don't have the re-duplication of the border… Yeah, this looks better. I only changed the second part to #messengerWindow[sizemode=normal] #mail-toolbox { border-bottom-color: ThreeDShadow; }
Attachment #583888 -
Attachment is obsolete: true
Attachment #584078 -
Flags: ui-review+
Attachment #584078 -
Flags: review+
(Assignee) | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 5•7 years ago
|
||
(In reply to Richard Marti [:paenglab] from comment #4) > > I don't see any other occurrences of "navigation-toolbox" in the code… Does > > this rule actually do anything? > This code makes the border around the menubar. "navigation-toolbox" is also > in primaryToolbar-aero.css at line 51, 93, 290 and 296. Ah, yes, I was looking at an older version of the code. My mistake. Thanks, Blake.
(Assignee) | ||
Updated•7 years ago
|
Attachment #584078 -
Flags: approval-comm-aurora?
Comment 6•7 years ago
|
||
Checked in to comm-central as http://hg.mozilla.org/comm-central/rev/3d887d2fce08
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
tracking-thunderbird11: --- → ?
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Updated•7 years ago
|
Attachment #584078 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 7•7 years ago
|
||
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/9bec4ba93f62
status-thunderbird11: --- → fixed
Updated•7 years ago
|
tracking-thunderbird11: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•