713446 - White text with text-shadow in selected bottom tabs

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Stefan [:stefanh]]

Bug 681425 added Lion-specific styling to selected tabs. The styling applies also to bottom tabs, which is wrong.

Comment 1

[Stefan [:stefanh]]

Attachment: Fix styling

I just added some rules to the existing selectors, no point using @media.

Comment 2

[Stefan [:stefanh]]

The patch in bug 681425 is in aurora, so we should fix it there too.

Comment 3

[Alex Keybl [:akeybl]]

Given the low-risk nature of this patch, we'd likely accept once r+'d. That being said, it's not yet clear that this needs to be tracked for FF11 since it's not explicitly stated where bottom tabs are used or why the user impact would be significant.

Comment 4

[Stefan [:stefanh]]

(In reply to Alex Keybl [:akeybl] from comment #3)
> Given the low-risk nature of this patch, we'd likely accept once r+'d. That
> being said, it's not yet clear that this needs to be tracked for FF11 since
> it's not explicitly stated where bottom tabs are used or why the user impact
> would be significant.

Two examples where bottom tabs are used: Chatzilla and SeaMonkey Composer. The white text with text-shadow makes it hard to see the tab title.

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Stefan [:stefanh] (away for a while) from comment #4)
> Two examples where bottom tabs are used: Chatzilla and SeaMonkey Composer.
> The white text with text-shadow makes it hard to see the tab title.

Thanks for the background. We're now tracking this for FF11.

Dao - can you review soon so that this can land on Aurora 11 earlier in the cycle? Thanks!

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ea2df08454f

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/1ea2df08454f

Comment 8

[Stefan [:stefanh]]

Comment on attachment 584268 [details] [diff] [review]
Fix styling

[Approval Request Comment]
Regression caused by: Bug 681425
User impact if declined: Hard to see tab titles in selected bottom tabs
Testing completed (on m-c, etc.): Has baked on m-c since 2012-01-30 19:15 PST
Risk to taking this patch (and alternatives if risky): No risk at all. Patch only sets the correct style rules for bottom tabs and these type of tabs doesn't exist in Firefox.
String changes made by this patch: None

Comment 9

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #8)
> Comment on attachment 584268 [details] [diff] [review]
> Fix styling
> 
> [Approval Request Comment]
> Regression caused by: Bug 681425
> User impact if declined: Hard to see tab titles in selected bottom tabs
> Testing completed (on m-c, etc.): Has baked on m-c since 2012-01-30 19:15 PST

19:09 to be more exact :-)

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 584268 [details] [diff] [review]
Fix styling

[Triage Comment]
Will only affect bottom tabs, and a low risk styling change. Approved for Beta 11.

Comment 11

[Stefan [:stefanh]]

http://hg.mozilla.org/releases/mozilla-beta/rev/8f077db91b79

Comment 12

[Vlad [QA]]

I have tried this on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0) Gecko/20100101 Firefox/11.0 beta 4

and the bottom tabs in ChatZilla and SeaMonkey Composer don't use Lion-specific styling anymore.

Considering this, setting the status to Verified Fixed on Firefox 11 beta