71383 - IMAP Other Users Namespace: Display "Shared Folders/User/" folder hierarchy incorrectly in folder pane

Status: NEW

(MailNews Core :: Networking: IMAP, defect)

Description

[Karen Huang]

Used 03-08-13-Mtrunk build

IMAP Namespace: Display "Shared Folders/User/" folder hierarchy incorrectly in 
folder pane

1)Specify one profile with 4.x preferences with Other Users "Shared 
Folders/User/" setup.
2)Migrated or create this profile in 6.5
3)Actual Results: The folder hierarchy seems to display incorrectly in current 
build folder pane (Please see the following 4.x & current build screen shots)
The "Shared Folders/User/", it treat "/" for subfolder...

Expected results: Should display "Shared Folders/User/" for one level folder as 
4.x screen shot.

Comment 1

[Karen Huang]

Attachment: attached 4.x screen shot for "Shared Folders/User/" correct folder hierarchy

Comment 2

[Karen Huang]

Attachment: attached current build screen shot for "Shared Folders/User/" incorrect folder hierarchy

Comment 3

[Karen Huang]

Nominating nsbeta1 based on Mach V PRD IMAP Shared Folders

Comment 4

[David :Bienvenu]

this might be very difficult - 4.x would check if the folder was a namespace and
not add an extra level of hierarchy, but the uri parsing code in 6.x would be
very unhappy with a namespace with the hierarchy delimiter in it that didn't
indicate a level in the hierarchy. Perhaps we could escape the hierarchy
delimiter and set the pretty name to be the namespace - anyway, this is going to
be tricky and have high potential for regressions, fyi.

Comment 5

[scottputterman]

moving to 1.0

Comment 6

[scottputterman]

moving out.

Comment 7

[Henry Jia]

CCing to myself

Comment 8

[philip zhao]

CC to myself. I agree with bienvenu's comment#4. 

Comment 9

[philip zhao]

We can control the hierarchy of folders *when they are created initially* as we
want.

Comment 10

[philip zhao]

Attachment: patch for test

This patch works on my iPlanet server just as "4.x screen shot for "Shared
Folders/User/" correct folder hierarchy".

You need to create new account with the otherusers namespace 'Shared
Folders/User/' for test.

Only fresh the folder pane won't let the code work if you already have one such
test account. You need create new *profile* and create new *account* to test.

Comment 11

[David :Bienvenu]

phillip, we don't use gotos as a general rules.

Comment 12

[philip zhao]

Ok, I will change it. Thanks! :-)

Comment 13

[philip zhao]

Attachment: patch for test

This patch has the same result with attachment 108003 [details] [diff] [review] .

Still a 'goto' in this patch. But if we delete it, I'm afraid we must duplicate
many same lines.

Do you think this will be ok? Thx! :-)

Comment 14

[Wayne Mery (:wsmwk)]

philip, does patch still work?

Comment 15

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 108137 [details] [diff] [review]
patch for test

Already bit-rotted, unfortunately.

$ patch -p0 --dry-run < ~/Desktop/tbTestPatches/nsImapMailFolder__CreateClientSubfolderInfo 
patching file nsImapIncomingServer.cpp
Hunk #1 FAILED at 1181.
1 out of 1 hunk FAILED -- saving rejects to file nsImapIncomingServer.cpp.rej
patching file nsImapMailFolder.cpp
Hunk #1 FAILED at 805.
Hunk #2 FAILED at 863.
2 out of 2 hunks FAILED -- saving rejects to file nsImapMailFolder.cpp.rej

Comment 16

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Moving back to NEW - there isn't any assignee email.