Expose manifest URL on devhub edit page

VERIFIED FIXED in 6.4.4

Status

P1
normal
VERIFIED FIXED
7 years ago
3 years ago

People

(Reporter: ianbicking, Assigned: cvan)

Tracking

unspecified
6.4.4
Dependency tree / graph

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Though data from the app manifest isn't used for very much (and what it is used for is editable), the location of the manifest itself cannot be changed.
(Assignee)

Updated

7 years ago
Assignee: nobody → cvan
Target Milestone: --- → 6.3.7
Target Milestone: 6.3.7 → 6.3.8
(Assignee)

Comment 1

7 years ago
Per fligtar, we will be allowing only admins to edit manifest URLs:

http://i.imgur.com/GjTf2.png

Developers will still be able to view the manifest URL - but until we've discussed this more, they will not be able to change it:

http://i.imgur.com/7L3ZA.png
Assignee: cvan → nobody
Component: Public Pages → Developer Pages
QA Contact: web-ui → developers
Summary: apps: there is no way to update an app manifest → Allow admins to edit manifest URL from devhub edit page
Target Milestone: 6.3.8 → 6.4.0
(Assignee)

Updated

7 years ago
Assignee: nobody → cvan
(Assignee)

Updated

7 years ago
Target Milestone: 6.4.0 → 6.4.1
(Assignee)

Comment 2

7 years ago
Once we can refresh manifests (that is, generate a new app version for the manifest file) in bug 719234, I'll update my commit accordingly and push this bad boy.
Depends on: 719234
Target Milestone: 6.4.1 → 6.4.2
(Assignee)

Updated

7 years ago
Priority: -- → P2
Summary: Allow admins to edit manifest URL from devhub edit page → Expose manifest URL on devhub edit page
Target Milestone: 6.4.2 → 6.4.3
(Assignee)

Updated

7 years ago
Blocks: 728355
Blocks: 710074

Comment 3

7 years ago
If we allow people to modify the domain, we should be respecting WEBAPPS_UNIQUE_BY_DOMAIN in this.
(Assignee)

Updated

7 years ago
Priority: P2 → P1
(Assignee)

Comment 4

7 years ago
https://github.com/mozilla/zamboni/commit/188c451

I've exposed the manifest URL so that it is *only visible* on the Edit Listing page. It is not editable by anyone.

If we decide we want to let developers edit the manifest URL, open a new bug. I figured we'd want to open up the discussion about whether to allow a manifest URL to be changed to a location with a different origin, etc. And I want more time to QA that - if that's what we in fact want.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: 6.4.3 → 6.4.4

Comment 5

7 years ago
verified that we show the manifest URL now. See https://marketplace-dev.allizom.org/en-US/developers/app/marble-run-39/edit
Status: RESOLVED → VERIFIED

Comment 6

7 years ago
Created attachment 601299 [details]
post-fix screenshot
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.