714167 - Expose manifest URL on devhub edit page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Ian Bicking (:ianbicking)]

Though data from the app manifest isn't used for very much (and what it is used for is editable), the location of the manifest itself cannot be changed.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Per fligtar, we will be allowing only admins to edit manifest URLs:

http://i.imgur.com/GjTf2.png

Developers will still be able to view the manifest URL - but until we've discussed this more, they will not be able to change it:

http://i.imgur.com/7L3ZA.png

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Once we can refresh manifests (that is, generate a new app version for the manifest file) in bug 719234, I'll update my commit accordingly and push this bad boy.

Comment 3

[Andy McKay]

If we allow people to modify the domain, we should be respecting WEBAPPS_UNIQUE_BY_DOMAIN in this.

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/188c451

I've exposed the manifest URL so that it is *only visible* on the Edit Listing page. It is not editable by anyone.

If we decide we want to let developers edit the manifest URL, open a new bug. I figured we'd want to open up the discussion about whether to allow a manifest URL to be changed to a location with a different origin, etc. And I want more time to QA that - if that's what we in fact want.

Comment 5

[krupa raj[:krupa]]

verified that we show the manifest URL now. See https://marketplace-dev.allizom.org/en-US/developers/app/marble-run-39/edit

Comment 6

[krupa raj[:krupa]]

Attachment: post-fix screenshot