714242 - nsHTMLPreElement should no longer recognize the @col attribute (don't support <pre col> from nav4)

Status: VERIFIED DUPLICATE of bug 949879

(Core :: DOM: Core & HTML, defect)

Description

[Ivan Enderlin]

Attachment: Test of the pre + @col + @with + nothing.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0a1) Gecko/20111229 Firefox/12.0a1
Build ID: 20111229031056

Steps to reproduce:

I have used the @col attribute on a <pre> HTML element.


Actual results:

It is recognized as a @width attribute (same behavior).


Expected results:

It should not be recognized :-).
The code is clear, in content/html/content/src/nsHTMLPreElement.cpp, at line 145: “width: int (html4 attribute == nav4 cols)” and at line 148: “cols: int (nav4 attribute)”. Maybe you keep this attribute for compatibility reasons but the @col attribute is never mentioned in HTML3.*, HTML4.* or HTML5. Is it Netscape only?
Thus, I propose to remove this attribute :-). I have a patch ready to be applied if you agree.

Comment 1

[j.j.]

Attachment: another testcase

Comment 2

[j.j.]

My testing on XP shows:

<pre col> is not supported by any other browser
<pre width> is not supported by IE and WebKit. Opera does, but doesn't break lines

Comment 3

[j.j.]

Browser support history:
  http://blooberry.com/indexdot/html/tagpages/p/pre.htm

Comment 4

[j.j.]

This attribute is not defined in any standard, not even as obsolete or deprecated feature.
http://www.w3.org/TR/html4/struct/text.html#edef-PRE
http://www.w3.org/html/wg/drafts/html/CR/obsolete.html#non-conforming-features

Comment 5

[Anne (:annevk)]

These all render identical to me. What's the bug?

Comment 6

[j.j.]

This seems to be fixed since Firefox 28, -> WFM

The bug was that <pre width=33> and <pre cols=33>
rendered like <pre style=width:33ch>

Comment 7

[j.j.]

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre
needs an update then
(do docs people pick up WFM-closed bugs?)

Comment 8

[j.j.]

> This seems to be fixed since Firefox 28, -> WFM

no, fixed since Firefox 29

Comment 10

[Anne (:annevk)]

Thanks!