Closed Bug 949879 Opened 7 years ago Closed 7 years ago

Drop support for <pre cols>

Categories

(Core :: Layout, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: emk, Assigned: emk)

References

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [DocArea=HTML])

Attachments

(1 file)

This is a non-standard extension derived from Navigator. It is not spec'ed and no other browsers support this. A standard alternative, width attribute, is available.
From a quick glance, I'd expect this would basically just require removing both usages of nsGkAtoms::cols from http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLPreElement.cpp , right?
Version: unspecified → Trunk
Priority: -- → P4
(In reply to Daniel Holbert [:dholbert] from comment #1)
> From a quick glance, I'd expect this would basically just require removing
> both usages of nsGkAtoms::cols from
> http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/
> HTMLPreElement.cpp , right?

Basically, yes. We can remove a bit more (usages in ParseAttribute and IsAttributeMapped).
Comment on attachment 8347216 [details] [diff] [review]
Drop support for "cols" attribute of <pre> elements

r=dbaron

But what other browsers support the width attribute?  It doesn't seem to be spec'd in HTML5 either, though it was in HTML4.  (Unless I'm looking in the wrong places, which I certainly could be.)
Attachment #8347216 - Flags: review?(dbaron) → review+
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-5) from comment #5)
> But what other browsers support the width attribute?

Other browsers have HTMLPreElement.width property which will reflect the content attribute.

> It doesn't seem to be
> spec'd in HTML5 either, though it was in HTML4.  (Unless I'm looking in the
> wrong places, which I certainly could be.)

It is defined in the HTML5 spec, but in the Obsolete features section.
http://www.whatwg.org/specs/web-apps/current-work/multipage/obsolete.html#HTMLPreElement-partial
Note that this is defined under "Requirements for implementations" subsection, so user agents must implement this as spec'ed despite that authors must not depend on this feature.

HTML5 spec says nothing about the layout effect of the attribute. Actually, it has no visual effect on other browsers. So I was planning to remove the visual effect of the width element, but in a follow-up bug.
> width element
width attribute, of course.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b78a373acbd
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Blocks: 950737
(In reply to Masatoshi Kimura [:emk] from comment #6)
> I was planning to remove the
> visual effect of the width element, but in a follow-up bug.

Filed bug 950737.
https://hg.mozilla.org/mozilla-central/rev/4b78a373acbd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [DocArea=HTML]
Duplicate of this bug: 714242
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre
needs an update then ("cols" and "width" attributes don't work since version 29)
You need to log in before you can comment on or make changes to this bug.