If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TransactionManager used as a service

RESOLVED FIXED in mozilla13

Status

()

Toolkit
Places
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: tetsuharu)

Tracking

12 Branch
mozilla13
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
TransactionManager is not a service.
well, we expose it through a lazy getter, so most likely it's just matter of swapping getService with createInstance.
thanks for the heads up!
Is this bug's purpose adding the lazy getter of nsITransactionManager to Services.jsm?
(Reporter)

Comment 3

6 years ago
This bug's purpose is to remove using TransactionManager as a service, because it is not a service.
so basically, I assume replace getService with createInstance is enough
Created attachment 598474 [details] [diff] [review]
Replace getService with createInstance
Attachment #598474 - Flags: review?(mak77)

Updated

6 years ago
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
Comment on attachment 598474 [details] [diff] [review]
Replace getService with createInstance

Review of attachment 598474 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #598474 - Flags: review?(mak77) → review+
Created attachment 600673 [details] [diff] [review]
[for check-in] Replace getService with createInstance v1.1

Rebased patch for check-in.
Attachment #600673 - Flags: review?(mak77)
Comment on attachment 600673 [details] [diff] [review]
[for check-in] Replace getService with createInstance v1.1

Review of attachment 600673 [details] [diff] [review]:
-----------------------------------------------------------------

thank you.
Attachment #600673 - Flags: review?(mak77) → review+

Updated

6 years ago
Attachment #598474 - Attachment is obsolete: true

Comment 9

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/029544f9423f

Thanks!
https://hg.mozilla.org/mozilla-central/rev/029544f9423f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Depends on: 731956
You need to log in before you can comment on or make changes to this bug.