Closed Bug 714261 Opened 9 years ago Closed 9 years ago

TransactionManager used as a service

Categories

(Toolkit :: Places, defect)

12 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: smaug, Assigned: tetsuharu)

References

Details

Attachments

(1 file, 1 obsolete file)

TransactionManager is not a service.
well, we expose it through a lazy getter, so most likely it's just matter of swapping getService with createInstance.
thanks for the heads up!
Is this bug's purpose adding the lazy getter of nsITransactionManager to Services.jsm?
This bug's purpose is to remove using TransactionManager as a service, because it is not a service.
so basically, I assume replace getService with createInstance is enough
Attachment #598474 - Flags: review?(mak77)
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
Comment on attachment 598474 [details] [diff] [review]
Replace getService with createInstance

Review of attachment 598474 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #598474 - Flags: review?(mak77) → review+
Rebased patch for check-in.
Attachment #600673 - Flags: review?(mak77)
Comment on attachment 600673 [details] [diff] [review]
[for check-in] Replace getService with createInstance v1.1

Review of attachment 600673 [details] [diff] [review]:
-----------------------------------------------------------------

thank you.
Attachment #600673 - Flags: review?(mak77) → review+
Attachment #598474 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/029544f9423f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
Depends on: 731956
You need to log in before you can comment on or make changes to this bug.