Last Comment Bug 714307 - Flickering display in emulator (need to copy updated region from front->back buffer in /dev/graphics/fb0 fallback)
: Flickering display in emulator (need to copy updated region from front->back ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla12
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on: 711867
Blocks:
  Show dependency treegraph
 
Reported: 2011-12-30 10:24 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2011-12-31 19:32 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Synchronize back/front buffers in gonk fallback path (4.44 KB, patch)
2011-12-30 10:56 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
no flags Details | Diff | Review
Synchronize back/front buffers in gonk fallback path, v2 (4.81 KB, patch)
2011-12-30 11:33 PST, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
mwu.code: review+
Details | Diff | Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-30 10:24:24 PST
With bug 711867 we only repaint the dirty region, but for this fallback path we need to do the front->back update of what was repainted.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-30 10:56:48 PST
Created attachment 584998 [details] [diff] [review]
Synchronize back/front buffers in gonk fallback path
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-30 11:33:37 PST
Created attachment 585003 [details] [diff] [review]
Synchronize back/front buffers in gonk fallback path, v2

Also sets the clipping region for the GL path, which I should have noticed in review.
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-30 11:35:32 PST
(Made a local change to
        static_cast<LayerManagerOGL*>(lm)->SetClippingRegion(event.region);
.)
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-12-30 18:29:45 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/b91a01700813
Comment 5 Phil Ringnalda (:philor) 2011-12-31 19:32:20 PST
https://hg.mozilla.org/mozilla-central/rev/b91a01700813

Note You need to log in before you can comment on or make changes to this bug.