714390 - Folder Location and Mail Views items are cut off in the customize toolbar dialog

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Jim Porter (:squib)]

Attachment: Notice the cut-off items at the bottom.

Bug 419231 changed how the Customize Toolbar dialog looks. Unfortunately, this results in some of our wider items getting cut off. We should do something about that. This could either mean 1) fix the issue in toolkit (easy), 2) overlay some CSS to fix the issue (hacky, but still easy), or 3) figure out a way to make the items narrower (not sure how hard this is).

Attached is a screenshot of the bug in action.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I would recommend overlaying some CSS to fix the issue. In Firefox, the "address bar" and "search bar" are both narrowed when in the customize window to fit the available width.

Comment 2

[Jim Porter (:squib)]

Attachment: Fix this

Here's a fix that shrinks the items to fit in the available space.

Comment 3

[Jim Porter (:squib)]

Attachment: What it looks like with the patch

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 585105 [details] [diff] [review]
Fix this

Code looks solid to me.  Great job!

-Mike

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 585105 [details] [diff] [review]
Fix this

Ok, so I actually have to reneg on my r+ for a few reasons here.

I just tried this patch on Windows 7, and my Customize Toolbar dialog is still showing the problem.  What's more, the buttons in the Customize Toolbar dialog are really tall now.

Secondly, a question on the code - if you're doing the queries by ID (#locationFolders, for example), why do we need the #palette-box portion of the selector?

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Here's a screenshot of my Windows 7 build with the patch:  http://i.imgur.com/xdken.png

Comment 7

[Jim Porter (:squib)]

(In reply to Mike Conley (:mconley) from comment #5)
> I just tried this patch on Windows 7, and my Customize Toolbar dialog is
> still showing the problem.  What's more, the buttons in the Customize
> Toolbar dialog are really tall now.

Do you see the tall buttons without the patch, too?

> Secondly, a question on the code - if you're doing the queries by ID
> (#locationFolders, for example), why do we need the #palette-box portion of
> the selector?

I only wanted the CSS rules to apply when the items are inside the palette, not when they're on the toolbar.

Comment 8

[Jim Porter (:squib)]

Oh, and as a followup, we might want to make sure that the "Icons beside text" dropdown uses the Windows 7 style and not our Firefox-inspired toolbar style. It looks a bit weird as it is.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 585105 [details] [diff] [review]
Fix this

Ok, so I'm a bit of a spaz today, and I failed to qpush your patch before compiling.  So that's why I didn't see the fix.

Having qpushed, yes, I see that your patch fixes the problem.

So yeah, the toolbar buttons were tall without your patch, so I don't think it causes it.  I'll file a separate bug.

Ok, I understand your explanation regarding the IDs.  r=me.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 585105 [details] [diff] [review]
Fix this

This works for me, and I'm confident enough about this that I'm willing to steal the ui-r from bwinton. :)

Great job squib,

-Mike

Comment 11

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/0d2d347a94df