Last Comment Bug 714390 - Folder Location and Mail Views items are cut off in the customize toolbar dialog
: Folder Location and Mail Views items are cut off in the customize toolbar dialog
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Toolbars and Tabs (show other bugs)
: Trunk
: All All
: -- minor (vote)
: Thunderbird 12.0
Assigned To: Jim Porter (:squib)
:
Mentors:
Depends on:
Blocks: 419231
  Show dependency treegraph
 
Reported: 2011-12-30 16:57 PST by Jim Porter (:squib)
Modified: 2012-01-05 19:40 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Notice the cut-off items at the bottom. (45.77 KB, image/png)
2011-12-30 16:57 PST, Jim Porter (:squib)
no flags Details
Fix this (2.38 KB, patch)
2011-12-30 19:35 PST, Jim Porter (:squib)
mconley: review+
mconley: ui‑review+
Details | Diff | Review
What it looks like with the patch (48.11 KB, image/png)
2011-12-30 19:36 PST, Jim Porter (:squib)
no flags Details

Description Jim Porter (:squib) 2011-12-30 16:57:19 PST
Created attachment 585082 [details]
Notice the cut-off items at the bottom.

Bug 419231 changed how the Customize Toolbar dialog looks. Unfortunately, this results in some of our wider items getting cut off. We should do something about that. This could either mean 1) fix the issue in toolkit (easy), 2) overlay some CSS to fix the issue (hacky, but still easy), or 3) figure out a way to make the items narrower (not sure how hard this is).

Attached is a screenshot of the bug in action.
Comment 1 Jared Wein [:jaws] (please needinfo? me) 2011-12-30 18:59:29 PST
I would recommend overlaying some CSS to fix the issue. In Firefox, the "address bar" and "search bar" are both narrowed when in the customize window to fit the available width.
Comment 2 Jim Porter (:squib) 2011-12-30 19:35:55 PST
Created attachment 585105 [details] [diff] [review]
Fix this

Here's a fix that shrinks the items to fit in the available space.
Comment 3 Jim Porter (:squib) 2011-12-30 19:36:57 PST
Created attachment 585106 [details]
What it looks like with the patch
Comment 4 Mike Conley (:mconley) - (needinfo me!) 2012-01-04 07:33:05 PST
Comment on attachment 585105 [details] [diff] [review]
Fix this

Code looks solid to me.  Great job!

-Mike
Comment 5 Mike Conley (:mconley) - (needinfo me!) 2012-01-04 08:24:21 PST
Comment on attachment 585105 [details] [diff] [review]
Fix this

Ok, so I actually have to reneg on my r+ for a few reasons here.

I just tried this patch on Windows 7, and my Customize Toolbar dialog is still showing the problem.  What's more, the buttons in the Customize Toolbar dialog are really tall now.

Secondly, a question on the code - if you're doing the queries by ID (#locationFolders, for example), why do we need the #palette-box portion of the selector?
Comment 6 Mike Conley (:mconley) - (needinfo me!) 2012-01-04 08:24:57 PST
Here's a screenshot of my Windows 7 build with the patch:  http://i.imgur.com/xdken.png
Comment 7 Jim Porter (:squib) 2012-01-04 09:34:39 PST
(In reply to Mike Conley (:mconley) from comment #5)
> I just tried this patch on Windows 7, and my Customize Toolbar dialog is
> still showing the problem.  What's more, the buttons in the Customize
> Toolbar dialog are really tall now.

Do you see the tall buttons without the patch, too?

> Secondly, a question on the code - if you're doing the queries by ID
> (#locationFolders, for example), why do we need the #palette-box portion of
> the selector?

I only wanted the CSS rules to apply when the items are inside the palette, not when they're on the toolbar.
Comment 8 Jim Porter (:squib) 2012-01-04 09:36:00 PST
Oh, and as a followup, we might want to make sure that the "Icons beside text" dropdown uses the Windows 7 style and not our Firefox-inspired toolbar style. It looks a bit weird as it is.
Comment 9 Mike Conley (:mconley) - (needinfo me!) 2012-01-04 10:16:50 PST
Comment on attachment 585105 [details] [diff] [review]
Fix this

Ok, so I'm a bit of a spaz today, and I failed to qpush your patch before compiling.  So that's why I didn't see the fix.

Having qpushed, yes, I see that your patch fixes the problem.

So yeah, the toolbar buttons were tall without your patch, so I don't think it causes it.  I'll file a separate bug.

Ok, I understand your explanation regarding the IDs.  r=me.
Comment 10 Mike Conley (:mconley) - (needinfo me!) 2012-01-05 11:46:54 PST
Comment on attachment 585105 [details] [diff] [review]
Fix this

This works for me, and I'm confident enough about this that I'm willing to steal the ui-r from bwinton. :)

Great job squib,

-Mike
Comment 11 Jim Porter (:squib) 2012-01-05 19:40:08 PST
Checked in: http://hg.mozilla.org/comm-central/rev/0d2d347a94df

Note You need to log in before you can comment on or make changes to this bug.