71460 - task bar buttons not firing

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Tracy Walker [:tracy]]

seen on windows commercial build 2001-03-09-06-mtrunk

-open composer
-type some miss spelled text
-click spellcheck icon
....it doesn't fire 
-also try adding horizontal line or image or table or link from the icons
.... none fire

these can all be worked around using the drop down menus

Comment 1

[sujay]

Cc: shrir.

Comment 2

[Simon Fraser [no longer active]]

is this related to bug 71224?

Comment 3

[Simon Fraser [no longer active]]

Spam

Comment 4

[kinmoz]

Charley, could it be possible that we are registering the composer commands on 
the wrong controller in ComposerCommands.js? You checked in some modifications 
to that area recently.

Comment 5

[Simon Fraser [no longer active]]

this is a bug in the modern skin. Toolbar buttons are stealing focus. Over to 
hewitt.

Comment 6

[Tracy Walker [:tracy]]

seeing linux 2001-03-09-10-mtrunk & mac 2001-03-09-11-trunk

changing platform to all

Comment 7

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 8

[Charles Manske]

Using "!important" makes sense, but why isn't the focus being ignored without
it?

Comment 9

[Joe Hewitt (gone)]

Good point Charley.  Seems that, for no good reason, there is a !important on
the -moz-user-focus for "button".  It's definitely more sensible to just remove
that !important and keep the other buttons sans !important.  

See upcoming patch

Comment 10

[Joe Hewitt (gone)]

Attachment: patch, rev2

Comment 11

[andreww]

r = andreww

Comment 12

[Joe Hewitt (gone)]

*** Bug 71624 has been marked as a duplicate of this bug. ***

Comment 13

[Joe Hewitt (gone)]

*** Bug 71772 has been marked as a duplicate of this bug. ***

Comment 14

[Joe Hewitt (gone)]

fixed

Comment 15

[Tracy Walker [:tracy]]

seen on linux 2001-03-13-05-mtrunk

all of the menu buttons are not functioning now, including the style buttons 
with the exception of the color pallete.

reopening

Comment 16

[Kathleen :Brade]

I'm not sure this bug should've been reopened.
This bug as now described is different from the original description.
Tracy--are you seeing bug #71224?

Comment 17

[Tracy Walker [:tracy]]

kind of like 71224....the buttons never appear enabled though, they definitely 
don't fire the function

Comment 18

[Kathleen :Brade]

The original bug is only for the modern skin (if I understand correctly).  
Tracy--Is this what you are seeing today?

Comment 19

[Tracy Walker [:tracy]]

this is affecting both modern and classic skins 

Comment 20

[Simon Fraser [no longer active]]

Issues here since the reopen are covered by bug 71224. Closing this again for the 
original fix (focus issues in skin).

Comment 21

[Tracy Walker [:tracy]]

verified commercial builds on 3/14