Closed
Bug 714606
Opened 13 years ago
Closed 13 years ago
Use Services.prompt instead of gPromptService in Toolkit
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
VERIFIED
FIXED
mozilla14
People
(Reporter: sgautherie, Assigned: aceman)
References
()
Details
Attachments
(1 file)
|
12.86 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
"Found 14 matching lines in 3 files"
This might need to add
Components.utils.import("resource://gre/modules/Services.jsm");
Flags: in-testsuite-
|
||
Updated•13 years ago
|
Severity: minor → trivial
Attachment #607662 -
Flags: review?(dtownsend+bugmail)
|
|
||
Updated•13 years ago
|
Attachment #607662 -
Flags: review?(dtownsend+bugmail) → review+
Keywords: checkin-needed
Whiteboard: [good first bug]
|
||
Comment 2•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla14
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc16cd4bda12#l1.31
> -const gPrefBranch = gPrefService.getBranch(null);
> +const gPrefBranch = Services.prefs.getBranch(null);
Is getBranch(null) here really necessary? Nothing here sets a branch is there?
If not then gPrefBranch can be directly replaced by Services.prefs.
Thanks, I got similar advice in bug 732807.
I have spun off bug 738568 for that.
You need to log in
before you can comment on or make changes to this bug.
Description
•