Use Services.prompt instead of gPromptService in Toolkit

VERIFIED FIXED in mozilla14

Status

()

Toolkit
General
--
trivial
VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: aceman)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
"Found 14 matching lines in 3 files"

This might need to add
Components.utils.import("resource://gre/modules/Services.jsm");
Flags: in-testsuite-
Severity: minor → trivial
(Assignee)

Updated

6 years ago
Assignee: nobody → acelists
(Assignee)

Comment 1

6 years ago
Created attachment 607662 [details] [diff] [review]
patch
Attachment #607662 - Flags: review?(dtownsend+bugmail)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Attachment #607662 - Flags: review?(dtownsend+bugmail) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [good first bug]
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc16cd4bda12
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/dc16cd4bda12
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

6 years ago
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc16cd4bda12#l1.31
> -const gPrefBranch = gPrefService.getBranch(null);
> +const gPrefBranch = Services.prefs.getBranch(null);
Is getBranch(null) here really necessary? Nothing here sets a branch is there?
If not then gPrefBranch can be directly replaced by Services.prefs.
(Assignee)

Updated

6 years ago
Blocks: 738568
(Assignee)

Comment 6

6 years ago
Thanks, I got similar advice in bug 732807.
I have spun off bug 738568 for that.
(Assignee)

Updated

6 years ago
Blocks: 754573
You need to log in before you can comment on or make changes to this bug.