Closed Bug 714606 Opened 10 years ago Closed 9 years ago

Use Services.prompt instead of gPromptService in Toolkit

Categories

(Toolkit :: General, defect)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla14

People

(Reporter: sgautherie, Assigned: aceman)

References

()

Details

Attachments

(1 file)

"Found 14 matching lines in 3 files"

This might need to add
Components.utils.import("resource://gre/modules/Services.jsm");
Flags: in-testsuite-
Severity: minor → trivial
Assignee: nobody → acelists
Attached patch patchSplinter Review
Attachment #607662 - Flags: review?(dtownsend+bugmail)
Status: NEW → ASSIGNED
Attachment #607662 - Flags: review?(dtownsend+bugmail) → review+
Keywords: checkin-needed
Whiteboard: [good first bug]
https://hg.mozilla.org/mozilla-central/rev/dc16cd4bda12
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
V.Fixed, per MXR search.
Status: RESOLVED → VERIFIED
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc16cd4bda12#l1.31
> -const gPrefBranch = gPrefService.getBranch(null);
> +const gPrefBranch = Services.prefs.getBranch(null);
Is getBranch(null) here really necessary? Nothing here sets a branch is there?
If not then gPrefBranch can be directly replaced by Services.prefs.
Blocks: 738568
Thanks, I got similar advice in bug 732807.
I have spun off bug 738568 for that.
Blocks: 754573
You need to log in before you can comment on or make changes to this bug.