rm lingering remains of JSCLASS_CONSTRUCT_PROTOTYPE

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Unassigned)

Tracking

unspecified
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 585346 [details] [diff] [review]
rm

Bug 702507 removed only half the mess.

 12 files changed, 129 insertions(+), 294 deletions(-)

The patch would be smaller, but I kept JS_ConstructObject(WithArguments) (it's not used in mozilla but it may still be of some use to embeddings) and moved InvokeConstructor to be next to InvokeConstructorKernel.  Lastly I s/JSFunction::isConstructor/JSFunction::isNativeConstructor/ since the former name confused me every time.
Attachment #585346 - Flags: review?(jwalden+bmo)
Comment on attachment 585346 [details] [diff] [review]
rm

Review of attachment 585346 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +3435,5 @@
> +                                uintN argc, jsval *argv)
> +{
> +    AssertNoGC(cx);
> +    CHECK_REQUEST(cx);
> +    assertSameCompartment(cx, JSValueArray(argv, argc));

No same-compartment assert for parent?
Attachment #585346 - Flags: review?(jwalden+bmo) → review+
(Reporter)

Comment 2

5 years ago
(In reply to Jeff Walden (remove +bmo to email) from comment #1)
> No same-compartment assert for parent?

Oops, I temporarily removed 'parent' and forgot to put this back.
(Reporter)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a917bd8e3f8e
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/a917bd8e3f8e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.