Closed Bug 714697 Opened 14 years ago Closed 14 years ago

rm lingering remains of JSCLASS_CONSTRUCT_PROTOTYPE

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: luke, Unassigned)

Details

Attachments

(1 file)

Attached patch rm — — Splinter Review
Bug 702507 removed only half the mess. 12 files changed, 129 insertions(+), 294 deletions(-) The patch would be smaller, but I kept JS_ConstructObject(WithArguments) (it's not used in mozilla but it may still be of some use to embeddings) and moved InvokeConstructor to be next to InvokeConstructorKernel. Lastly I s/JSFunction::isConstructor/JSFunction::isNativeConstructor/ since the former name confused me every time.
Attachment #585346 - Flags: review?(jwalden+bmo)
Comment on attachment 585346 [details] [diff] [review] rm Review of attachment 585346 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsapi.cpp @@ +3435,5 @@ > + uintN argc, jsval *argv) > +{ > + AssertNoGC(cx); > + CHECK_REQUEST(cx); > + assertSameCompartment(cx, JSValueArray(argv, argc)); No same-compartment assert for parent?
Attachment #585346 - Flags: review?(jwalden+bmo) → review+
(In reply to Jeff Walden (remove +bmo to email) from comment #1) > No same-compartment assert for parent? Oops, I temporarily removed 'parent' and forgot to put this back.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: