714697 - rm lingering remains of JSCLASS_CONSTRUCT_PROTOTYPE

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm

Bug 702507 removed only half the mess.

 12 files changed, 129 insertions(+), 294 deletions(-)

The patch would be smaller, but I kept JS_ConstructObject(WithArguments) (it's not used in mozilla but it may still be of some use to embeddings) and moved InvokeConstructor to be next to InvokeConstructorKernel.  Lastly I s/JSFunction::isConstructor/JSFunction::isNativeConstructor/ since the former name confused me every time.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 585346 [details] [diff] [review]
rm

Review of attachment 585346 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +3435,5 @@
> +                                uintN argc, jsval *argv)
> +{
> +    AssertNoGC(cx);
> +    CHECK_REQUEST(cx);
> +    assertSameCompartment(cx, JSValueArray(argv, argc));

No same-compartment assert for parent?

Comment 2

[Luke Wagner [:luke]]

(In reply to Jeff Walden (remove +bmo to email) from comment #1)
> No same-compartment assert for parent?

Oops, I temporarily removed 'parent' and forgot to put this back.

Comment 3

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a917bd8e3f8e

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/a917bd8e3f8e