714787 - Permanent permission not saved for location after "Clearing site settings" and reloading page 5 times

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120102 Firefox/12.0a1 Fennec/12.0a1
Device: Samsung Nexus S
OS: Android 2.3

Steps to reproduce:
1. Go to html5demos.com/geo
2. On the door hanger select "Share".
3. Repeat steps 1 and 2: 5 times. ->A permanent permission was saved, so after the 5th time door hanger is not displayed any more.
4. Go to Menu->More->Clear Site Settings
5. Go to html5demos.com/geo
6. On the door hanger select "Share".
7. Repeat steps 1 and 2: 5 times.

Expected results:
 After the 5th time a permanent permission was saved, so door hanger is not displayed anymore.

Actual results: 
 Permanent permission was not saved, door hanger is displayed.

Note:
 - I tried reloading page more than 10 times, and every time I selected "share", and the door hanger is displayed every time.

Comment 1

[:Margaret Leibovic]

Attachment: patch

We also need to clear the content prefs that are set in setPagePermission in ContentPermissionPrompt.js.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 586612 [details] [diff] [review]
patch

Review of attachment 586612 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but do we also have to do something like:

http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/sanitize.js#149

If so, follow up.  If not, okay :D

Comment 3

[:Margaret Leibovic]

(In reply to Doug Turner (:dougt) from comment #2) 
> This is fine, but do we also have to do something like:
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/
> sanitize.js#149

This is weird - why is that code clearing normal prefs, but we're setting the request.remember stuff in contentPrefs? Did we switch to using contentPrefs at some point? If that's the case, maybe we need a follow-up bug to clean up sanitize.js.

Comment 4

[:Margaret Leibovic]

(In reply to Margaret Leibovic [:margaret] from comment #3)
> (In reply to Doug Turner (:dougt) from comment #2) 
> > This is fine, but do we also have to do something like:
> > 
> > http://mxr.mozilla.org/mozilla-central/source/mobile/xul/chrome/content/
> > sanitize.js#149
> 
> This is weird - why is that code clearing normal prefs, but we're setting
> the request.remember stuff in contentPrefs? Did we switch to using
> contentPrefs at some point? If that's the case, maybe we need a follow-up
> bug to clean up sanitize.js.

Yeah, some archeology led me to this: http://hg.mozilla.org/mozilla-central/rev/61024744dcae. I filed bug 716722 about fixing sanitize.js.

Landed this on inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c05c5afca65

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3c05c5afca65

Comment 6

[:Margaret Leibovic]

Comment on attachment 586612 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): not a regression
User impact if declined: after clearing site settings, permanent permissions don't work anymore
Testing completed (on m-c, etc.): I just tested on Nightly and it worked
Risk to taking this patch (and alternatives if risky): none

Note to QA: Your profile will be messed up if you cleared site settings before this bug landed, so you need to test with a new site or a new profile.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 586612 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Carla Nadastean]

Verified with: 
Nightly 12.0a1 (2012-01-12) HTC Desire Z (Android 2.3)
Permanent permision is saved after "Clear Site Settings" and reloading page 5 times.

Reproducible on Aurora:
11.0a2 (2012-01-12) HTC Desire Z (Android 2.3)

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0e14b61f5682

Comment 10

[Catalin Suciu [:csuciu]]

Verified fixed on Aurora 11.0a2 (2012-01-18)
Device: Samsung Galaxy S2 (Android 2.3.4)