714941 - Internal Mozilla Phonebook entries don't display properly using Nightly

Status: RESOLVED DUPLICATE of bug 718757

(Webtools Graveyard :: Phonebook, defect)

Description

[Josh Aas]

Internal Mozilla Phonebook entries are broken using Firefox Nightly builds. They don't show their white backgrounds properly, making the entries hard to read.

Comment 1

[Josh Aas]

Attachment: picture of problem, with details blanked out

Comment 3

[Daniel Holbert [:dholbert]]

Regression range on trunk:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c5b90ea7e475&tochange=f63a99195987

That points to this changeset:
> 	William Chen — Bug 497995: Part 1 - Implement border-image revisions in latest css3-background spec. r=dbaron
http://hg.mozilla.org/mozilla-central/rev/dda1146d1ec3

When I load a phonebook page, I get this in error console:
> Warning: Unknown property 'border-image'.  Declaration dropped.
> Source File: https://phonebook.mozilla.org/css/style.css
> Line: 229
which points to:
>  .vcard .header {
>    border-image: url(../img/vcard_header_bg.png) 0 132 0 16 repeat stretch;

...and:
> Warning: Unknown property 'border-image'.  Declaration dropped.
> Source File: https://phonebook.mozilla.org/css/style.css
> Line: 251
which points to:
>  .vcard .body {
>    border-image: url(../img/vcard_body_bg.png) 0 16 0 16 repeat repeat;

This all sounds like like phonebook needs to update to use the latest CSS3 border-image syntax. (while possibly preserving the old syntax too, for older versions of Firefox)

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> When I load a phonebook page, I get this in error console:
> > Warning: Unknown property 'border-image'.  Declaration dropped.

Oh, sorry -- I skimmed over the error-message without actually reading it.  I thought it was an "invalid syntax" error message, but it's just saying that we don't yet use the "border-image" name for the property, so it gets dropped. (but phonebook provides -moz-border-image as well, which is honored)

So basically, ignore the second half of my previous comment, sorry for the noise.

Comment 5

[Daniel Holbert [:dholbert]]

It looks like Bug 713643 (unprixing border-image) will make it easier for phonebook to support older & newer Firefox versions simultaneously.

Once the property is unprefixed, we can use the new syntax in "border-image" declarations and the old syntax in "-moz-border-image" declarations.

Comment 8

[Fred Wenzel [:wenzel]]

Can we remove the "confidential" flag on this bug, please? AFAICT there is no private data revealed here, and this is a CSS bug, AND the phonebook code is open source, so no reason to keep the bug private. Thanks!

Comment 9

[Daniel Holbert [:dholbert]]

Agreed; clearing that flag. (I suspect this was originally marked as MoCo-internal largely on the assumption that it's simply not relevant outside of MoCo (not that that really matters))

> AND the phonebook code is open source

Cool, I didn't know that! That definitely makes it relevant outside of MoCo. :)

Comment 10

[Fred Wenzel [:wenzel]]

(In reply to Daniel Holbert [:dholbert] from comment #9)
> Agreed; clearing that flag.

Thanks! I'd have done it myself but wanted to make sure I am not missing something.

Comment 11

[Phil Ringnalda (:philor)]

Duping forward to yet another duplicate, which was also confidential, but has a patch. That confidential stuff sure works out well, doesn't it?