Get rid of MOZALLOC_INLINE

REOPENED
Assigned to

Status

()

REOPENED
7 years ago
7 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 585695 [details] [diff] [review]
Patch v1

This macro is essentially the same as MOZ_ALWAYS_INLINE from mfbt.
Attachment #585695 - Flags: review?(mh+mozilla)
Attachment #585695 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 1

7 years ago
https://hg.mozilla.org/mozilla-central/rev/d5f3e38021fd
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
(Assignee)

Updated

7 years ago
Depends on: 717441
(Assignee)

Comment 2

7 years ago
Had to back it out because of Fennec crashes

https://hg.mozilla.org/integration/mozilla-inbound/rev/88acaad9c766
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla12 → ---
Oh, I see how this could have failed:

#if defined(DEBUG)
#  define MOZ_ALWAYS_INLINE     MOZ_INLINE

It doesn't always inline on debug builds, which means there are actual calls to new/delete, and chances are they end up being linked to stlport instead of mozalloc on android.
You need to log in before you can comment on or make changes to this bug.