Closed
Bug 715093
Opened 13 years ago
Closed 2 years ago
Get rid of MOZALLOC_INLINE
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
DUPLICATE
of bug 1423461
People
(Reporter: Ms2ger, Unassigned)
References
Details
Attachments
(1 file)
|
4.01 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This macro is essentially the same as MOZ_ALWAYS_INLINE from mfbt.
Attachment #585695 -
Flags: review?(mh+mozilla)
|
||
Updated•13 years ago
|
Attachment #585695 -
Flags: review?(mh+mozilla) → review+
|
Reporter | |
Comment 1•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
|
Reporter | |
Comment 2•13 years ago
|
||
Had to back it out because of Fennec crashes
https://hg.mozilla.org/integration/mozilla-inbound/rev/88acaad9c766
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla12 → ---
|
|
||
Comment 3•13 years ago
|
||
Oh, I see how this could have failed:
#if defined(DEBUG)
# define MOZ_ALWAYS_INLINE MOZ_INLINE
It doesn't always inline on debug builds, which means there are actual calls to new/delete, and chances are they end up being linked to stlport instead of mozalloc on android.
|
||
Comment 4•13 years ago
|
||
|
||
Comment 5•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: Ms2ger → nobody
|
||
Comment 6•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → Ms2ger
|
|
Reporter | |
Updated•2 years ago
|
Assignee: Ms2ger → nobody
Status: REOPENED → RESOLVED
Closed: 13 years ago → 2 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•