715093 - Get rid of MOZALLOC_INLINE

Status: RESOLVED DUPLICATE of bug 1423461

(Core :: General, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

This macro is essentially the same as MOZ_ALWAYS_INLINE from mfbt.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d5f3e38021fd

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Had to back it out because of Fennec crashes

https://hg.mozilla.org/integration/mozilla-inbound/rev/88acaad9c766

Comment 3

[Mike Hommey [:glandium]]

Oh, I see how this could have failed:

#if defined(DEBUG)
#  define MOZ_ALWAYS_INLINE     MOZ_INLINE

It doesn't always inline on debug builds, which means there are actual calls to new/delete, and chances are they end up being linked to stlport instead of mozalloc on android.

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/88acaad9c766

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 6

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.