Open Bug 715093 Opened 10 years ago Updated 10 years ago

Get rid of MOZALLOC_INLINE

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

REOPENED

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
This macro is essentially the same as MOZ_ALWAYS_INLINE from mfbt.
Attachment #585695 - Flags: review?(mh+mozilla)
Attachment #585695 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/d5f3e38021fd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Depends on: 717441
Had to back it out because of Fennec crashes

https://hg.mozilla.org/integration/mozilla-inbound/rev/88acaad9c766
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla12 → ---
Oh, I see how this could have failed:

#if defined(DEBUG)
#  define MOZ_ALWAYS_INLINE     MOZ_INLINE

It doesn't always inline on debug builds, which means there are actual calls to new/delete, and chances are they end up being linked to stlport instead of mozalloc on android.
You need to log in before you can comment on or make changes to this bug.