715163 - Mouse click + drag causing Tilt to Translate instead of Rotate on First Open

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Rob Campbell [:rc] (:robcee)]

STR:

1. Open Tilt on a page.
2. Click with mouse (trackpad) and drag around

Expected results:

Page is rotated.

Actual:

Sometimes the page translates instead of rotates.

Not sure why this is happening but it seems to only happen the first time Tilt is opened. Subsequent drag events work as expected.

Comment 1

[Victor Porof [:vporof][:vp]]

I really can't reproduce this :(

Comment 2

[Victor Porof [:vporof][:vp]]

I may have found a reason for this: Tilt is opened using Ctr+W (or Ctr+M before bug 711966). Ctrl+Click changes left click to right click. Right click + drag = translate, while left click + drag = rotate.

So whenever you do Ctrl+Click + drag you get translation. Is this the problem?

Comment 3

[Rob Campbell [:rc] (:robcee)]

Hm! Maybe. It usually happens after I've opened Tilt and start dragging. There could be something to the right-click to translate function. All I know is that it's confusing when it happens. I'll watch my fingers the next time I see it.

Comment 4

[Victor Porof [:vporof][:vp]]

I could disable all events for a split second when you open Tilt. This would allow the initial animation to finish (and also even avoid any of that weird znear/zfar clipping if you have fast fingers). How about that?

Comment 5

[Rob Campbell [:rc] (:robcee)]

Can we do this and increase the speed of the intro animation? We want the UI to be responsive within 50ms.

Comment 6

[Victor Porof [:vporof][:vp]]

It's a plan.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 8

[Rob Campbell [:rc] (:robcee)]

did you want review on this patch? No request present and it's a blocker for bug 718973.

Comment 9

[Victor Porof [:vporof][:vp]]

(In reply to Rob Campbell [:rc] (robcee) from comment #8)
> did you want review on this patch? No request present and it's a blocker for
> bug 718973.

Yes please :)

Comment 10

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/85fbc84de818

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/85fbc84de818

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 589134 [details] [diff] [review]
v1

[Approval Request Comment]
Regression caused by (bug #): New Feature
User impact if declined: Occasional accidental tranlation
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Pretty minimal changes.