Closed Bug 715163 Opened 9 years ago Closed 9 years ago

Mouse click + drag causing Tilt to Translate instead of Rotate on First Open

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rcampbell, Assigned: vporof)

References

Details

(Whiteboard: [tilt])

Attachments

(1 file)

STR:

1. Open Tilt on a page.
2. Click with mouse (trackpad) and drag around

Expected results:

Page is rotated.

Actual:

Sometimes the page translates instead of rotates.

Not sure why this is happening but it seems to only happen the first time Tilt is opened. Subsequent drag events work as expected.
Whiteboard: [tilt]
I really can't reproduce this :(
I may have found a reason for this: Tilt is opened using Ctr+W (or Ctr+M before bug 711966). Ctrl+Click changes left click to right click. Right click + drag = translate, while left click + drag = rotate.

So whenever you do Ctrl+Click + drag you get translation. Is this the problem?
Hm! Maybe. It usually happens after I've opened Tilt and start dragging. There could be something to the right-click to translate function. All I know is that it's confusing when it happens. I'll watch my fingers the next time I see it.
I could disable all events for a split second when you open Tilt. This would allow the initial animation to finish (and also even avoid any of that weird znear/zfar clipping if you have fast fingers). How about that?
Can we do this and increase the speed of the intro animation? We want the UI to be responsive within 50ms.
It's a plan.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Depends on: 718425
Blocks: 718973
did you want review on this patch? No request present and it's a blocker for bug 718973.
(In reply to Rob Campbell [:rc] (robcee) from comment #8)
> did you want review on this patch? No request present and it's a blocker for
> bug 718973.

Yes please :)
Attachment #589134 - Flags: review?(rcampbell)
Attachment #589134 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/integration/fx-team/rev/85fbc84de818
Whiteboard: [tilt] → [tilt][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/85fbc84de818
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [tilt][fixed-in-fx-team] → [tilt]
Target Milestone: --- → Firefox 12
Comment on attachment 589134 [details] [diff] [review]
v1

[Approval Request Comment]
Regression caused by (bug #): New Feature
User impact if declined: Occasional accidental tranlation
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Pretty minimal changes.
Attachment #589134 - Flags: approval-mozilla-aurora?
Target Milestone: Firefox 12 → ---
Attachment #589134 - Flags: approval-mozilla-aurora?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.