Last Comment Bug 715210 - Remove some WINCE leftovers in comm-central
: Remove some WINCE leftovers in comm-central
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Windows CE
: -- trivial (vote)
: Thunderbird 12.0
Assigned To: Serge Gautherie (:sgautherie)
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 614720 715555
  Show dependency treegraph
 
Reported: 2012-01-04 10:51 PST by Serge Gautherie (:sgautherie)
Modified: 2012-01-05 10:06 PST (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Remove 4 more WINCE occurrences [Checked in: Comment 2] (2.93 KB, patch)
2012-01-04 11:02 PST, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review
(Bv1) Remove last "wince" occurrence (in Imap code) [Checked in: See comment 5] (1.20 KB, patch)
2012-01-04 13:11 PST, Serge Gautherie (:sgautherie)
mozilla: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2012-01-04 10:51:57 PST
NB: For this bug, I am ignoring config* files.
Comment 1 Serge Gautherie (:sgautherie) 2012-01-04 11:02:06 PST
Created attachment 585817 [details] [diff] [review]
(Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]

I am not sure what to do with
{
/mailnews/imap/src/nsImapProtocol.cpp
    * line 7219 -- // global variable for unusued name spaces from??? *wince*
}
so I left it alone too.
Comment 2 Serge Gautherie (:sgautherie) 2012-01-04 12:59:04 PST
Comment on attachment 585817 [details] [diff] [review]
(Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/9eda40ffb503
Comment 3 Serge Gautherie (:sgautherie) 2012-01-04 13:11:54 PST
Created attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> I am not sure what to do ...
> so I left it alone too.

Ah, it just occurred to me that this occurrence is not referencing Windows CE ;->
Let's remove it anyway: "code cleanup".
Comment 4 David :Bienvenu 2012-01-05 09:16:34 PST
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

kinda sad that we can't use the perfectly good word "wince" in our comments. I'll r+ it for the tab removal. In any case, can you fix the spelling of unused? thx.
Comment 5 Serge Gautherie (:sgautherie) 2012-01-05 10:00:34 PST
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

http://hg.mozilla.org/comm-central/rev/7fd4f1e85fa0
Bv1, with comment 4 suggestion(s).

Note You need to log in before you can comment on or make changes to this bug.