Remove some WINCE leftovers in comm-central

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Build Config
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
Thunderbird 12.0
x86
Windows CE
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
NB: For this bug, I am ignoring config* files.
Flags: in-testsuite-
(Assignee)

Comment 1

5 years ago
Created attachment 585817 [details] [diff] [review]
(Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]

I am not sure what to do with
{
/mailnews/imap/src/nsImapProtocol.cpp
    * line 7219 -- // global variable for unusued name spaces from??? *wince*
}
so I left it alone too.
Attachment #585817 - Flags: review?(mbanner)

Updated

5 years ago
Attachment #585817 - Flags: review?(mbanner) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 585817 [details] [diff] [review]
(Av1) Remove 4 more WINCE occurrences
[Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/9eda40ffb503
Attachment #585817 - Attachment description: (Av1) Remove 4 more WINCE occurrences → (Av1) Remove 4 more WINCE occurrences [Checked in: Comment 2]
(Assignee)

Comment 3

5 years ago
Created attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

(In reply to Serge Gautherie (:sgautherie) from comment #1)
> I am not sure what to do ...
> so I left it alone too.

Ah, it just occurred to me that this occurrence is not referencing Windows CE ;->
Let's remove it anyway: "code cleanup".
Attachment #585864 - Flags: review?(dbienvenu)

Comment 4

5 years ago
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

kinda sad that we can't use the perfectly good word "wince" in our comments. I'll r+ it for the tab removal. In any case, can you fix the spelling of unused? thx.
Attachment #585864 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 5

5 years ago
Comment on attachment 585864 [details] [diff] [review]
(Bv1) Remove last "wince" occurrence (in Imap code)
[Checked in: See comment 5]

http://hg.mozilla.org/comm-central/rev/7fd4f1e85fa0
Bv1, with comment 4 suggestion(s).
Attachment #585864 - Attachment description: (Bv1) Remove last "wince" occurrence (in Imap code) → (Bv1) Remove last "wince" occurrence (in Imap code) [Checked in: See comment 5]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 715555
You need to log in before you can comment on or make changes to this bug.