715225 - Clean up menu contents

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Ian Barlow (:ibarlow)]

There are some items in the menu that probably shoudn't be there anymore, or should be re-ordered. 

CC-ing Madhava on this for the final list.

Comment 1

[Erin Lancaster [:elan]]

It would be wonderful to have these changes complete in due time prior to the 16th string freeze date.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's get this list ASAP :)

Comment 3

[Madhava Enros [:madhava]]

The set is

Reload
Forward
Bookmark
Share
Save as PDF
--------------- + "More" pre-ICS; the rest are in the secondary 
Clear Site Settings (disabled when not applicable)
Add-ons
Downloads
Settings
Quit

So, the delta with what we have now is:
- remove "Request Desktop Site"
- some minor reorg
- Clear Site Settings should be disabled when it's not applicable

Comment 4

[:Margaret Leibovic]

(In reply to Madhava Enros [:madhava] from comment #3)

> So, the delta with what we have now is:
> - Clear Site Settings should be disabled when it's not applicable

FYI, this is bug 711774.

Comment 5

[Peter Retzer (:pretzer)]

(In reply to Madhava Enros [:madhava] from comment #3)
> So, the delta with what we have now is:
> - remove "Request Desktop Site"

And this was already fixed by bug 711774. So the only thing left for this bug is:

> - some minor reorg

Comment 6

[Peter Retzer (:pretzer)]

Doh! I meant bug 709888 in my comment above. Sorry for the spam.

Comment 7

[Brian Nicholson (:bnicholson)]

In anticipation of bug 701824, where in this list do we want Character Encoding?

Comment 8

[Axel Hecht [:Pike]]

Does putting menu items into secondary have an impact on the space constraints for the menu item? If so, does that grow or shrink?

Comment 9

[Brian Nicholson (:bnicholson)]

Doing a quick test on my Droid Razr, the constraints were exactly the same for vertical orientation. For horizontal orientation, the secondary list was more constrained since the primary menu expands to width of the display, but the secondary menu does not.

Comment 10

[Brian Nicholson (:bnicholson)]

Attachment: patch

Comment 11

[Brian Nicholson (:bnicholson)]

Landed on inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/9b15fc2bd106

Comment 12

[Brian Nicholson (:bnicholson)]

Comment on attachment 590284 [details] [diff] [review]
patch

[Approval Request Comment]
trivial patch for menu reordering. no risk.

Comment 13

[Axel Hecht [:Pike]]

(In reply to Brian Nicholson (:bnicholson) from comment #9)
> Doing a quick test on my Droid Razr, the constraints were exactly the same
> for vertical orientation. For horizontal orientation, the secondary list was
> more constrained since the primary menu expands to width of the display, but
> the secondary menu does not.

That sounds to me that the constrained secondary in horizontal is still wider than in vertical?

Sounds like little l10n impact if at all, but either way, it'd be good to land this soooon if approved.

Comment 14

[Brian Nicholson (:bnicholson)]

(In reply to Axel Hecht [:Pike] from comment #13)
> (In reply to Brian Nicholson (:bnicholson) from comment #9)
> > Doing a quick test on my Droid Razr, the constraints were exactly the same
> > for vertical orientation. For horizontal orientation, the secondary list was
> > more constrained since the primary menu expands to width of the display, but
> > the secondary menu does not.
> 
> That sounds to me that the constrained secondary in horizontal is still
> wider than in vertical?
> 
> Sounds like little l10n impact if at all, but either way, it'd be good to
> land this soooon if approved.

For me, the secondary menu was constrained to the exact same width in both orientations.

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9b15fc2bd106

Comment 16

[Alex Keybl [:akeybl]]

Comment on attachment 590284 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a8866ee8dff5

Comment 18

[Aaron Train [:aaronmt]]

Verified on M-A & M-C
Galaxy Nexus (Android 4.0.3)

20120126053754
http://hg.mozilla.org/releases/mozilla-aurora/rev/9d5ede8cb11a

20120126031113
http://hg.mozilla.org/mozilla-central/rev/402b394b6623