715589 - Stop sleeping in elastic's refresh()

Status: VERIFIED FIXED

(support.mozilla.org :: Search, defect)

Description

[Erik Rose [:erik][:erikrose]]

In the refresh() calls from es_search.index_doc(), we hit refresh's default behavior, which is to sleep for 1 second afterward. This isn't a killer, since it's off on a task (all the time?), but it's still unnecessary. Here's where the author of ES says so: http://elasticsearch-users.115913.n3.nabble.com/Client-refresh-in-unit-tests-not-always-fast-enough-td1695708.html. Let's pass timesleep=0 to refresh().

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was fixed in https://github.com/mozilla/kitsune/commit/85936b11e91c375e3fec9b86f12e0ad069f92524

If it landed on or around the 5th, then it got into next on the 10th and will go out on the 17th. So I'm marking it as such.

Making it [qa-]--there's no good way to test this.

Comment 2

[Rebecca Billings [:rbillings]]

Closed as [qa-]