If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Stop sleeping in elastic's refresh()

VERIFIED FIXED in 2012-01-17

Status

support.mozilla.org
Search
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: erik, Unassigned)

Tracking

unspecified
2012-01-17

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Reporter)

Description

6 years ago
In the refresh() calls from es_search.index_doc(), we hit refresh's default behavior, which is to sleep for 1 second afterward. This isn't a killer, since it's off on a task (all the time?), but it's still unnecessary. Here's where the author of ES says so: http://elasticsearch-users.115913.n3.nabble.com/Client-refresh-in-unit-tests-not-always-fast-enough-td1695708.html. Let's pass timesleep=0 to refresh().
This was fixed in https://github.com/mozilla/kitsune/commit/85936b11e91c375e3fec9b86f12e0ad069f92524

If it landed on or around the 5th, then it got into next on the 10th and will go out on the 17th. So I'm marking it as such.

Making it [qa-]--there's no good way to test this.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: 2012Q1 → 2012-01-17
Closed as [qa-]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.