Last Comment Bug 715618 - SharedLibrary operator= doesn't handle self assignment properly
: SharedLibrary operator= doesn't handle self assignment properly
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: Benoit Girard (:BenWa)
:
:
Mentors:
Depends on:
Blocks: 713227
  Show dependency treegraph
 
Reported: 2012-01-05 12:10 PST by Benoit Girard (:BenWa)
Modified: 2013-06-05 09:15 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.49 KB, patch)
2012-01-05 12:12 PST, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Splinter Review
patch v2 (1.54 KB, patch)
2012-01-05 15:12 PST, Benoit Girard (:BenWa)
mats: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-01-05 12:10:59 PST

    
Comment 1 Benoit Girard (:BenWa) 2012-01-05 12:12:23 PST
Created attachment 586174 [details] [diff] [review]
patch
Comment 2 Mats Palmgren (:mats) 2012-01-05 12:24:13 PST
Actually, don't you need a free() as well?

SharedLibrary x(...,"x");
SharedLibrary y(...,"y");
x = y;

the copy of "x" leaks?
Comment 3 Benoit Girard (:BenWa) 2012-01-05 15:12:12 PST
Created attachment 586242 [details] [diff] [review]
patch v2
Comment 5 Ed Morley [:emorley] 2012-01-06 15:47:03 PST
https://hg.mozilla.org/mozilla-central/rev/4083764d3c63

Note You need to log in before you can comment on or make changes to this bug.