Closed Bug 715618 Opened 8 years ago Closed 8 years ago

SharedLibrary operator= doesn't handle self assignment properly

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla12

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
1.54 KB, patch
mats
: review+
Details | Diff | Splinter Review 
No description provided.
Blocks: 713227
Attached patch patch (obsolete) — — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #586174 - Flags: review?(jmuizelaar)
Attachment #586174 - Flags: review?(jmuizelaar) → review+
Actually, don't you need a free() as well?

SharedLibrary x(...,"x");
SharedLibrary y(...,"y");
x = y;

the copy of "x" leaks?
Attached patch patch v2 — — Splinter Review
Attachment #586174 - Attachment is obsolete: true
Attachment #586242 - Flags: review?(matspal)
Attachment #586242 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/4083764d3c63
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Component: General → Gecko Profiler
You need to log in before you can comment on or make changes to this bug.