SharedLibrary operator= doesn't handle self assignment properly

RESOLVED FIXED in mozilla12

Status

()

Product:
Core
Component:
Gecko Profiler
RESOLVED FIXED
Reported:
6 years ago
Modified:
4 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Version:
Trunk
Target:
mozilla12
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

patch v2
1.54 KB, patch
mats
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

•
6 years ago
Blocks: 713227
 (Assignee)

Comment 1

•
6 years ago 
Created attachment 586174 [details] [diff] [review]
patch
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #586174 - Flags: review?(jmuizelaar)
Attachment #586174 - Flags: review?(jmuizelaar) → review+

Comment 2

•
6 years ago 
Actually, don't you need a free() as well?

SharedLibrary x(...,"x");
SharedLibrary y(...,"y");
x = y;

the copy of "x" leaks?
 (Assignee)

Comment 3

•
6 years ago 
Created attachment 586242 [details] [diff] [review]
patch v2
Attachment #586174 - Attachment is obsolete: true
Attachment #586242 - Flags: review?(matspal)

Updated

•
6 years ago
Attachment #586242 - Flags: review?(matspal) → review+
 (Assignee)

Comment 4

•
6 years ago 
https://hg.mozilla.org/integration/mozilla-inbound/rev/4083764d3c63

Comment 5

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/4083764d3c63
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
 (Assignee)

Updated

•
4 years ago
Component: General → Gecko Profiler
You need to log in before you can comment on or make changes to this bug.