Detail view icon has no dimensions set, causes a relayout when it loads

RESOLVED FIXED in mozilla12

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

unspecified
mozilla12
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The content of the detail view shifts to the right when the icon loads. Since there's no good way of knowing the icon's dimensions, I propose wrapping it in a 64px wide block aligned to the right.

Also, I think we should use a 64px puzzle piece as the default instead of the current 32px.
For some some fun background reading, see bug 633640.
Blocks: 633640
(Assignee)

Comment 2

6 years ago
Created attachment 587249 [details] [diff] [review]
patch
Attachment #587249 - Flags: review?(bmcbride)
Comment on attachment 587249 [details] [diff] [review]
patch

Review of attachment 587249 [details] [diff] [review]:
-----------------------------------------------------------------

Much better, ty :)
Attachment #587249 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0a14d58397
Flags: in-testsuite-
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/4c0a14d58397
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.