Bug 679476 causes crash in [@ mime_parse_stream_complete]

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
MIME
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: Bienvenu)

Tracking

({crash, regression, topcrash})

Trunk
Thunderbird 12.0
x86
Windows NT
crash, regression, topcrash

Thunderbird Tracking Flags

(thunderbird9 affected, thunderbird10+ fixed, thunderbird11 fixed)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
mdd->messageBody is null


This bug was filed from the Socorro interface and is 
report bp-56635412-cbe7-436d-be2c-73e532120103 .
============================================================= 
0 	xul.dll 	mime_parse_stream_complete 	mailnews/mime/src/mimedrft.cpp:1610
1 	xul.dll 	nsStreamConverter::OnStopRequest 	mailnews/mime/src/nsStreamConverter.cpp:1090
2 	xul.dll 	nsStreamListenerTee::OnStopRequest 	netwerk/base/src/nsStreamListenerTee.cpp:71
3 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
4 	xul.dll 	nsProxyObjectCallInfo::Run 	xpcom/proxy/src/nsProxyEvent.cpp:182
5 	xul.dll 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:631
6 	xul.dll 	NS_ProcessNextEvent_P 	objdir-tb/mozilla/xpcom/build/nsThreadUtils.cpp:245
7 	xul.dll 	mozilla::ipc::MessagePump::Run 	ipc/glue/MessagePump.cpp:134
8 	xul.dll 	MessageLoop::RunInternal 	ipc/chromium/src/base/message_loop.cc:208
9 	xul.dll 	MessageLoop::RunHandler 	ipc/chromium/src/base/message_loop.cc:201
10 	xul.dll 	MessageLoop::Run 	ipc/chromium/src/base/message_loop.cc:175
11 	xul.dll 	nsBaseAppShell::Run 	widget/src/xpwidgets/nsBaseAppShell.cpp:189
12 	xul.dll 	nsAppShell::Run 	widget/src/windows/nsAppShell.cpp:261
13 	xul.dll 	nsAppStartup::Run 	toolkit/components/startup/nsAppStartup.cpp:228
14 	xul.dll 	XRE_main 	toolkit/xre/nsAppRunner.cpp:3557
15 	thunderbird.exe 	do_main 	mail/app/nsMailApp.cpp:143
16 	thunderbird.exe 	NS_internal_main 	mail/app/nsMailApp.cpp:226
17 	thunderbird.exe 	wmain 	toolkit/xre/nsWindowsWMain.cpp:107
18 	thunderbird.exe 	__tmainCRTStartup 	crtexe.c:594
19 	kernel32.dll 	BaseProcessStart
(Reporter)

Updated

6 years ago
Component: Migration → MIME
Product: Thunderbird → MailNews Core
QA Contact: migration → mime
(Reporter)

Updated

6 years ago
status-thunderbird10: --- → affected
status-thunderbird11: --- → affected
status-thunderbird12: --- → affected
status-thunderbird9: --- → affected
same as bug 564701?
(Reporter)

Comment 2

6 years ago
(In reply to Wayne Mery (:wsmwk) from comment #1)
> same as bug 564701?

No.  When filing bug 564701, bug 679476 isn't landed.
(Reporter)

Comment 3

6 years ago
This crash appears from 9.0 and top 3 crash into 9.0.1 now.
Do we have any idea what can cause this?
(In reply to Mark Banner (:standard8) from comment #4)
> Do we have any idea what can cause this?

or rather, trigger it.
(In reply to Makoto Kato from comment #2)
> (In reply to Wayne Mery (:wsmwk) from comment #1)
> > same as bug 564701?
> 
> No.  When filing bug 564701, bug 679476 isn't landed.

then I understand you to say this is a regression from bug 679476
Keywords: regression
(Assignee)

Comment 7

6 years ago
Any ideas about steps to reproduce the issue? We can bullet-proof it, of course, but we won't know if there are issues downstream.
tracking-thunderbird10: --- → ?
(Assignee)

Comment 8

6 years ago
Created attachment 587353 [details] [diff] [review]
bulletproof fix

since this is a top crash, we should protect against it.
Assignee: nobody → dbienvenu
Status: NEW → ASSIGNED
Attachment #587353 - Flags: review?(mbanner)
(Reporter)

Comment 9

6 years ago
(In reply to David :Bienvenu from comment #7)
> Any ideas about steps to reproduce the issue? We can bullet-proof it, of
> course, but we won't know if there are issues downstream.

I don't know.  I think that it depends on mail header and body.
Comment on attachment 587353 [details] [diff] [review]
bulletproof fix

r=me, lets get this in on branches as well.
Attachment #587353 - Flags: review?(mbanner)
Attachment #587353 - Flags: review+
Attachment #587353 - Flags: approval-comm-beta+
Attachment #587353 - Flags: approval-comm-aurora+
(Assignee)

Comment 11

6 years ago
fixed on trunk - http://hg.mozilla.org/comm-central/rev/6c76c5640293 - if standard8 doesn't beat me to it, I'll try to transplant this to the branches later when I'm on my mac.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Checked into branches:

http://hg.mozilla.org/releases/comm-aurora/rev/19f2edf25ef9
http://hg.mozilla.org/releases/comm-beta/rev/fabf6e73f3b6
status-thunderbird10: affected → fixed
status-thunderbird11: affected → fixed
status-thunderbird12: affected → ---
tracking-thunderbird10: ? → +
Keywords: topcrash
You need to log in before you can comment on or make changes to this bug.