The default bug view has changed. See this FAQ.

android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nhirata, Assigned: kats)

Tracking

({regression})

12 Branch
Firefox 12
Other
Linux
regression
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

(URL)

Attachments

(3 attachments)

Created attachment 586357 [details]
logcat

1. go to http://www.wechoosethemoon.org
2. look at logcat

Expected: no errors
Actual: 
01-06 08:39:10.625: W/System.err(381): android.view.ViewRoot$CalledFromWrongThreadException: Only the original thread that created a view hierarchy can touch its views.
01-06 08:39:10.636: W/System.err(381): 	at android.view.ViewRoot.checkThread(ViewRoot.java:2932)

Note:
1. It's not crashing, just an error
2. nexus s, 2.3.1; flash 11, 20120105
3. bug 703256 fixed the crash
Regression introduced in 58a278555680 (bug 710096). It shouldn't be hard to fix. I'm going to take some time to re-review the threading model of all the pan/zoom code though, there are definitely more bugs lurking there.
Assignee: nobody → bugmail.mozilla
Keywords: regression

Updated

5 years ago
tracking-firefox11: --- → +
Priority: -- → P2

Updated

5 years ago
tracking-fennec: --- → 11+
tracking-firefox11: + → ---
Created attachment 588177 [details] [diff] [review]
(1/2) Remove unused functions that call repositionPluginViews

Just in case somebody calls these in the future from the wrong thread.
Attachment #588177 - Flags: review?(pwalton)
Created attachment 588178 [details] [diff] [review]
(2/2) Make sure repositionPluginViews is called on the UI thread
Attachment #588178 - Flags: review?(pwalton)
Comment on attachment 588177 [details] [diff] [review]
(1/2) Remove unused functions that call repositionPluginViews

Review of attachment 588177 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup catch.
Attachment #588177 - Flags: review?(pwalton) → review+
Comment on attachment 588178 [details] [diff] [review]
(2/2) Make sure repositionPluginViews is called on the UI thread

Review of attachment 588178 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #588178 - Flags: review?(pwalton) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/317592537ff6
https://hg.mozilla.org/integration/mozilla-inbound/rev/157c86d30692
status-firefox11: --- → affected
status-firefox12: --- → affected
You can set the status-firefoxN and Target Milestone fields when landing on inbound; it saves some work for the inbound mergers.
status-firefox12: affected → fixed
Target Milestone: --- → Firefox 12
https://hg.mozilla.org/mozilla-central/rev/317592537ff6
https://hg.mozilla.org/mozilla-central/rev/157c86d30692
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 588177 [details] [diff] [review]
(1/2) Remove unused functions that call repositionPluginViews

[Approval Request Comment (for both patches)]
Regression caused by (bug #): bug 710096
User impact if declined: possible races and errors as UI things are accessed from a non-UI thread
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): pretty low-risk; one patches removes dead code (errors will be caught by compiler) and the other patch moves a chunk of code to another thread
Attachment #588177 - Flags: approval-mozilla-aurora?
Attachment #588178 - Flags: approval-mozilla-aurora?
Comment on attachment 588177 [details] [diff] [review]
(1/2) Remove unused functions that call repositionPluginViews

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #588177 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #588178 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/bd8a953a2717
https://hg.mozilla.org/releases/mozilla-aurora/rev/524dcbfd9363
status-firefox11: affected → fixed
You need to log in before you can comment on or make changes to this bug.