The default bug view has changed. See this FAQ.

Change the order of -framework options when linking XUL so that it works on 10.6 -> 10.5 builds

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

12 Branch
mozilla12
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 586403 [details] [diff] [review]
Change the order of -framework options when linking XUL so that it works on 10.6 -> 10.5 builds

On the 10.6 SDK and newer, the symbol _SCDynamicStoreCreate is visible in multiple freameworks:

$ nm SystemConfiguration  | grep -w _SCDynamicStoreCreate
0000000000002be7 T _SCDynamicStoreCreate

$ nm IOKit  | grep -w _SCDynamicStoreCreate$
00000000000579cc S $ld$hide$os10.7$_SCDynamicStoreCreate
000000000001ed66 T _SCDynamicStoreCreate

This is not a problem when the linker is run with a deployment target of 10.6, because it does the right thing and uses the symbol from SystemConfiguration.

It is also not a problem when using the 10.5 SDK, since _SCDynamicStoreCreate is only visible in SystemConfiguration in there.

The problem is when using the 10.6 SDK and a deployment target of 10.5. The resulting binary will use _SCDynamicStoreCreate from what is first on the command line. The first framework with _SCDynamicStoreCreate in the XUL link is IOKit, so XUL will find that symbol at runtime only when running on 10.6.

To fix this, we just have to make sure that "-framework SystemConfiguration" comes before "-framework IOKit". That is what this patch does.

https://tbpl.mozilla.org/?tree=Try&rev=bfe15ae3738c
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #586403 - Flags: review?(ted.mielczarek)
Blocks: 715397
Attachment #586403 - Flags: review?(ted.mielczarek) → review+
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=25fe3fddc59e
https://hg.mozilla.org/mozilla-central/rev/25fe3fddc59e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.