Closed Bug 715928 Opened 8 years ago Closed 8 years ago

thumbnails not updated (or not able to be generated for some internal pages?)

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
blocking-fennec1.0 --- +
fennec 11+ ---

People

(Reporter: dietrich, Assigned: sriram)

Details

(Whiteboard: [reviewed patch])

Attachments

(2 files)

working from today's aurora build:

* thumbnail for about:home on about:home is blank white

* thumbnail for about:addons is light blue with the embossed firefox logo (the no-image image maybe?)
Whiteboard: [testday-20120106]
OS: Mac OS X → Android
Hardware: x86 → ARM
Assignee: nobody → snorp
tracking-fennec: --- → 11+
Priority: -- → P2
Ian, we purposely don't screenshot about:home because it'll just show up as all white. Do you want to include a stock thumbnail to show for it as a special case?
Assignee: snorp → ibarlow
Hi Brad, we actually shouldn't be showing thumbnails of about: pages at all on the start page, as per bug 710392.

That said, as a general rule whenever thumbnails aren't showing up, we should be using the light blue placeholder image that Dietrich referred to.
Ian - what about in the tab menu? When the about:home page is open, it has a crappy tab thumbnail in the tab list (menu)
As per our conversation in IRC, I'll make a special "about:home" thumbnail for use in the tab menu, and post it here soon.
Poke poke, Ian?
blocking-fennec1.0: --- → +
Status: NEW → ASSIGNED
(In reply to Ian Barlow (:ibarlow) from comment #6)
> Created attachment 600391 [details]
> Start Page placeholder thumbnails for tab menu

These thumbnails won't work out when about:home recieves a channel-branded styling (bug 710260). Is that considered a problem?
Hm, yes I would consider that a problem. 

I'll make some channel branded ones as well.
Assignee: ibarlow → sriram
I need new set of resources. Currently we use 136 X 78 for the thumbnails. @ibarlow: Could you please post newer ones?
Attached patch PatchSplinter Review
This patch shows the awesome thumbnail in Tabs-tray. :)
However, I need newer resources. Once I get them, I can replace those.
Attachment #605950 - Flags: review?(mark.finkle)
Comment on attachment 605950 [details] [diff] [review]
Patch


>+  res/drawable/abouthome.png \

>+  res/drawable-hdpi/abouthome.png \

>+  res/drawable-xhdpi-v11/abouthome.png \

>+            else if (TextUtils.equals(tab.getURL(), ABOUT_HOME))
>+                thumbnail.setImageResource(R.drawable.abouthome);

rename the resource to "abouthome_thumbnail"

Also, the resources have an extremely large footprint size. Can we try to reduce the size a bit?

r+ with the changes addressed. don't land until Ian get's newer (and hopefully smaller) resources.
Attachment #605950 - Flags: review?(mark.finkle) → review+
Whiteboard: [testday-20120106] → [reviewed patch][needs ibarlow]
Sriram, here are updated assets, also in Nightly and Aurora flavours! http://cl.ly/2x1b172x0w3M3K2y1y2X

(sorry for the cloud link, my bugzilla uploader is busted again)

I've included PNG and JPGs, feel free to use either. The PNGs are still around the same file size as before, but the JPGs are considerably smaller.
Whiteboard: [reviewed patch][needs ibarlow] → [reviewed patch]
http://hg.mozilla.org/integration/mozilla-inbound/rev/f2f066e1abce

Pushed the patch for Firefox alone. Saving the other thumbnails to be landed when we implement content-branded UI.
https://hg.mozilla.org/mozilla-central/rev/f2f066e1abce
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Version: unspecified → Trunk
Verified/fixed on:

Nightly Fennec 14.0a1 (2012-03-23)
Device: Samsung Nexus S
OS: Android 2.3.6
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.