Closed
Bug 715928
Opened 13 years ago
Closed 13 years ago
thumbnails not updated (or not able to be generated for some internal pages?)
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox13 fixed, firefox14 fixed, blocking-fennec1.0 +, fennec11+)
VERIFIED
FIXED
Firefox 14
People
(Reporter: dietrich, Assigned: sriram)
Details
(Whiteboard: [reviewed patch])
Attachments
(2 files)
116.67 KB,
application/zip
|
Details | |
153.56 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
working from today's aurora build: * thumbnail for about:home on about:home is blank white * thumbnail for about:addons is light blue with the embossed firefox logo (the no-image image maybe?)
Reporter | ||
Updated•13 years ago
|
Whiteboard: [testday-20120106]
Updated•13 years ago
|
OS: Mac OS X → Android
Hardware: x86 → ARM
Updated•13 years ago
|
Assignee: nobody → snorp
tracking-fennec: --- → 11+
Priority: -- → P2
Comment 1•13 years ago
|
||
Ian, we purposely don't screenshot about:home because it'll just show up as all white. Do you want to include a stock thumbnail to show for it as a special case?
Assignee: snorp → ibarlow
Comment 2•13 years ago
|
||
Hi Brad, we actually shouldn't be showing thumbnails of about: pages at all on the start page, as per bug 710392. That said, as a general rule whenever thumbnails aren't showing up, we should be using the light blue placeholder image that Dietrich referred to.
Comment 3•13 years ago
|
||
Ian - what about in the tab menu? When the about:home page is open, it has a crappy tab thumbnail in the tab list (menu)
Comment 4•13 years ago
|
||
As per our conversation in IRC, I'll make a special "about:home" thumbnail for use in the tab menu, and post it here soon.
Updated•13 years ago
|
Keywords: fennecnative-releaseblocker
Comment 6•13 years ago
|
||
Updated•13 years ago
|
blocking-fennec1.0: --- → +
Updated•13 years ago
|
Status: NEW → ASSIGNED
Comment 7•13 years ago
|
||
(In reply to Ian Barlow (:ibarlow) from comment #6) > Created attachment 600391 [details] > Start Page placeholder thumbnails for tab menu These thumbnails won't work out when about:home recieves a channel-branded styling (bug 710260). Is that considered a problem?
Comment 8•13 years ago
|
||
Hm, yes I would consider that a problem. I'll make some channel branded ones as well.
Updated•13 years ago
|
Assignee: ibarlow → sriram
Assignee | ||
Comment 9•13 years ago
|
||
I need new set of resources. Currently we use 136 X 78 for the thumbnails. @ibarlow: Could you please post newer ones?
Assignee | ||
Comment 10•13 years ago
|
||
This patch shows the awesome thumbnail in Tabs-tray. :) However, I need newer resources. Once I get them, I can replace those.
Attachment #605950 -
Flags: review?(mark.finkle)
Comment 11•13 years ago
|
||
Comment on attachment 605950 [details] [diff] [review] Patch >+ res/drawable/abouthome.png \ >+ res/drawable-hdpi/abouthome.png \ >+ res/drawable-xhdpi-v11/abouthome.png \ >+ else if (TextUtils.equals(tab.getURL(), ABOUT_HOME)) >+ thumbnail.setImageResource(R.drawable.abouthome); rename the resource to "abouthome_thumbnail" Also, the resources have an extremely large footprint size. Can we try to reduce the size a bit? r+ with the changes addressed. don't land until Ian get's newer (and hopefully smaller) resources.
Attachment #605950 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
Whiteboard: [testday-20120106] → [reviewed patch][needs ibarlow]
Comment 12•13 years ago
|
||
Sriram, here are updated assets, also in Nightly and Aurora flavours! http://cl.ly/2x1b172x0w3M3K2y1y2X (sorry for the cloud link, my bugzilla uploader is busted again) I've included PNG and JPGs, feel free to use either. The PNGs are still around the same file size as before, but the JPGs are considerably smaller.
Updated•13 years ago
|
Whiteboard: [reviewed patch][needs ibarlow] → [reviewed patch]
Assignee | ||
Comment 13•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/f2f066e1abce Pushed the patch for Firefox alone. Saving the other thumbnails to be landed when we implement content-branded UI.
Comment 14•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f2f066e1abce
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Version: unspecified → Trunk
Comment 15•13 years ago
|
||
Verified/fixed on: Nightly Fennec 14.0a1 (2012-03-23) Device: Samsung Nexus S OS: Android 2.3.6
Status: RESOLVED → VERIFIED
Comment 16•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ba444b71df2f
status-firefox13:
--- → fixed
status-firefox14:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•